Introduce a findAllWhereFieldEquals method

[buehner]

This introduces a findAllWhereFieldEquals method to DAO and service layer, which is very useful and can be used with PersistentObjects and primitve types, too.

[annarieger]

LGTM!
Could you provide the tests for the new methods?

[buehner]

I pushed some commits that add tests for all new methods. On top of that, i added tests for the recently introduced method findAllWithCollectionContaining

[marcjansen]

I generally approve this, because this method will become quite useful. Yet I have added a couple of comments which you might want to think about and possibly take.

Thanks and please merge after commenting on my comments.

[marcjansen]

Message could be enhanced to read e.g.

String errorMsg = String.format(
	"There is no field '%s' in the type '%s' that accepts instances of '%s'",
	fieldName,
	entityClass.getName(),
	// beware of null, though
	fieldEntity.getClass().getName()
);

[marcjansen]

What happens if fieldEntity is null?

I would assume that isField becomes false and one runs into the IllegalArgumentException (at least if you take my suggestion of also checking the type).

But this is a valid question, right? Please find me all instances of E where the field named fieldName is (or is not) null. What do you think?

I think we could branch off to a dfifferent method in the service, but this comes from the top of my head.

[marcjansen]

Wouldn't it be better to also check for the accepoted type, here or in another method?

Slightly related, we keep passing forceAccess around, but on all SHOGun2 model classe we must have it true, since our models only have private fields. We should probably remove this everywhere, ansd simply pass through true. This could be done in another PR of course, and only if you agree.

[buehner]

I think i "finalized" this in 8c3e31b by also handling null values. Please review (and merge!?) @marcjansen

[marcjansen]

Looking into this now.

[marcjansen]

Very nice, Nils. Merging now. Thanks a lot!