-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auditing: add tracking of modified fields #301
Merged
LukasLohoff
merged 10 commits into
terrestris:master
from
LukasLohoff:audit-mod-tracking
Apr 13, 2021
Merged
Auditing: add tracking of modified fields #301
LukasLohoff
merged 10 commits into
terrestris:master
from
LukasLohoff:audit-mod-tracking
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasLohoff
force-pushed
the
audit-mod-tracking
branch
from
April 12, 2021 07:40
05386b5
to
1c0b6d8
Compare
LukasLohoff
force-pushed
the
audit-mod-tracking
branch
from
April 12, 2021 07:46
1c0b6d8
to
ce9d180
Compare
LukasLohoff
changed the title
WIP: Audit mod tracking
Auditing: add tracking of modified fields
Apr 12, 2021
ahennr
reviewed
Apr 12, 2021
shogun-lib/src/main/java/de/terrestris/shogun/lib/envers/CustomAnnotationRevisionMetadata.java
Outdated
Show resolved
Hide resolved
shogun-lib/src/main/java/de/terrestris/shogun/lib/envers/CustomAnnotationRevisionMetadata.java
Outdated
Show resolved
Hide resolved
ahennr
reviewed
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work @LukasLohoff 🔝 , just some minor issues
shogun-lib/src/main/java/de/terrestris/shogun/lib/envers/CustomAnnotationRevisionMetadata.java
Outdated
Show resolved
Hide resolved
...src/main/java/de/terrestris/shogun/lib/envers/CustomEnversRevisionRepositoryFactoryBean.java
Outdated
Show resolved
Hide resolved
...lib/src/main/java/de/terrestris/shogun/lib/repository/impl/CustomRevisionRepositoryImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: André Henn <henn@terrestris.de>
…to audit-mod-tracking
dnlkoch
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @LukasLohoff!
ahennr
approved these changes
Apr 13, 2021
Thanks for reviewing 👍 |
Very impressive work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables tracking of modified columns in audit tables.
findRevisions
now contains a new propertycontent.metadata.changedFields
which contains all of the property names (on class level, not database) of changed fields in that revision.RevisionRepository
interface & implementation and overrides a couple of classes to integrate modified column information into revision metadata_mod
column to each entity via migrationUses and modifies some classes from https://github.com/spring-projects/spring-data-envers which is licensed under the Apache 2.0 license.
@terrestris/devs Please review