Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev dockerfile #393

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Fix dev dockerfile #393

merged 4 commits into from
Oct 5, 2021

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Oct 5, 2021 •
edited
Loading

This suggests:

  • To make use of the same openjdk base image as in production (referenced by the jib plugin).
  • To set the correct workdir path and
  • To set the default application servlet path to /.

Replaces #390 and requires #21 (shogun-docker).

Please review @terrestris/devs.

@dnlkoch dnlkoch mentioned this pull request Oct 5, 2021
Merged
@dnlkoch dnlkoch marked this pull request as ready for review October 5, 2021 08:55
@dnlkoch dnlkoch mentioned this pull request Oct 5, 2021
Closed
@LukasLohoff
Copy link
Member

Startup action will be repaired in another MR

@LukasLohoff LukasLohoff merged commit d898ed9 into main Oct 5, 2021
@dnlkoch dnlkoch deleted the fix-dev-dockerfile branch February 15, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbllmnn hwbllmnn hwbllmnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnlkoch @LukasLohoff @hwbllmnn