Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller integration tests #407

Merged
merged 17 commits into from
Oct 19, 2021
Merged

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Oct 8, 2021

Description

This adds some basic integration tests for the CRUD-REST interfaces (/applications, /layers, /groups, /users) checking if:

  • An anonymous has no permission to create, read, update and delete an entity.
  • An admin user has the permission to create, read, update and delete all entities (without any particular permissions set).
  • A default user has no permission to create, read, update and delete an entity (without any particular permissions set).
  • A default user has the permission to create, read, update and delete an entity (while having the particular permissions set).

Depends on #405 and #406.

Please review @terrestris/devs.

Related issues or pull requests

--

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 326 files.

Valid Invalid Ignored Fixed
228 8 90 0
Click to see the invalid file list
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/config/AuditConfig.java
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/config/MethodSecurityConfig.java
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/config/WebConfig.java
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/config/WebSecurityConfig.java
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/controller/ApplicationControllerTest.java
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/controller/BaseControllerTest.java
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/controller/IBaseController.java
  • shogun-lib/src/test/java/de/terrestris/shogun/lib/controller/UserControllerTest.java

@dnlkoch dnlkoch force-pushed the add-controller-integration-tests branch from cb35590 to cda6dc3 Compare October 16, 2021 13:26
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@terrestris terrestris deleted a comment from github-actions bot Oct 16, 2021
@dnlkoch dnlkoch force-pushed the add-controller-integration-tests branch 2 times, most recently from 9b8fb21 to ce0aeb4 Compare October 18, 2021 10:02
@dnlkoch dnlkoch marked this pull request as ready for review October 18, 2021 10:07
@dnlkoch dnlkoch force-pushed the add-controller-integration-tests branch from ce0aeb4 to 959c1d1 Compare October 18, 2021 10:12
@dnlkoch
Copy link
Member Author

dnlkoch commented Oct 19, 2021

Thanks for the review!

@dnlkoch dnlkoch merged commit 985d81e into main Oct 19, 2021
@dnlkoch dnlkoch deleted the add-controller-integration-tests branch October 19, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants