-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mirror] Add more parameters to common types #2745
Conversation
Hi, @ruowan Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
… version preview/2023-02-01-preview (Azure#23221) * Adds base for updating Microsoft.ContainerInstance from version stable/2022-09-01 to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * added property * added sample request and responses * integer format * read only property * read only fix * custom word * changed boolean to enum * changed boolean to enum in examples * x-ms-enum
* added properties property for operation object * updated older api version as well * prettier fix * use full description for properties object * remove 'type' * use correct property name
Hi @ruowan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @ruowan, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @ruowan, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
Hi @ruowan This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main. |
Mirror from
https://github.com/Azure/azure-rest-api-specs/pull/21420