Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mirror] Add more parameters to common types #2745

Merged
merged 4 commits into from
Mar 31, 2023

Conversation

ruowan
Copy link

@ruowan ruowan commented Nov 8, 2022

Mirror from https://github.com/Azure/azure-rest-api-specs/pull/21420

@workflow-bot-test
Copy link

Hi, @ruowan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app-test
    Copy link

    openapi-pipeline-app-test bot commented Nov 8, 2022

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️🔄~[Staging] Lint(RPaaS) inProgress [Detail]
    ️⌛ApiReadinessCheck pending [Detail]
    ️🔄~[Staging] ServiceAPIReadinessTest inProgress [Detail]
    ️🔄~[Staging] SwaggerAPIView inProgress [Detail]
    ️⌛CredScan pending [Detail]
    ️⌛PoliCheck pending [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️🔄SemanticValidation inProgress [Detail]
    ️🔄~[Staging] PrettierCheck inProgress [Detail]
    ️️✔️~[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️🔄[Staging] SDK Track2 Validation inProgress [Detail]
    ️⌛PR Summary pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app-test
    Copy link

    openapi-pipeline-app-test bot commented Nov 8, 2022

    Swagger Generation Artifacts

    ️️✔️~[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b396f5a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.3
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.3>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.3` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-communication [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group CommunicationServicesOperations
      info	[Changelog]   - Added operation group DomainsOperations
      info	[Changelog]   - Added operation group EmailServicesOperations
      info	[Changelog]   - Added operation group SenderUsernamesOperations
      info	[Changelog]   - Model CommunicationServiceResource has a new parameter linked_domains
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Parameter location of model CommunicationServiceResource is now required
      info	[Changelog]   - Removed operation group CommunicationServiceOperations
      info	[Changelog]   - Removed operation group OperationStatusesOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b396f5a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/communication/armcommunication [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ServiceProperties.ProvisioningState` has been changed from `*ProvisioningState` to `*CommunicationServicesProvisioningState`
      info	[Changelog] - Function `NewServiceClient` has been removed
      info	[Changelog] - Function `*ServiceClient.CheckNameAvailability` has been removed
      info	[Changelog] - Function `*ServiceClient.BeginCreateOrUpdate` has been removed
      info	[Changelog] - Function `*ServiceClient.BeginDelete` has been removed
      info	[Changelog] - Function `*ServiceClient.Get` has been removed
      info	[Changelog] - Function `*ServiceClient.LinkNotificationHub` has been removed
      info	[Changelog] - Function `*ServiceClient.NewListByResourceGroupPager` has been removed
      info	[Changelog] - Function `*ServiceClient.NewListBySubscriptionPager` has been removed
      info	[Changelog] - Function `*ServiceClient.ListKeys` has been removed
      info	[Changelog] - Function `*ServiceClient.RegenerateKey` has been removed
      info	[Changelog] - Function `*ServiceClient.Update` has been removed
      info	[Changelog] - Struct `LocationResource` has been removed
      info	[Changelog] - Struct `NameAvailability` has been removed
      info	[Changelog] - Struct `ServiceClient` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `CheckNameAvailabilityReason` with values `CheckNameAvailabilityReasonAlreadyExists`, `CheckNameAvailabilityReasonInvalid`
      info	[Changelog] - New enum type `CommunicationServicesProvisioningState` with values `CommunicationServicesProvisioningStateCanceled`, `CommunicationServicesProvisioningStateCreating`, `CommunicationServicesProvisioningStateDeleting`, `CommunicationServicesProvisioningStateFailed`, `CommunicationServicesProvisioningStateMoving`, `CommunicationServicesProvisioningStateRunning`, `CommunicationServicesProvisioningStateSucceeded`, `CommunicationServicesProvisioningStateUnknown`, `CommunicationServicesProvisioningStateUpdating`
      info	[Changelog] - New enum type `DomainManagement` with values `DomainManagementAzureManaged`, `DomainManagementCustomerManaged`, `DomainManagementCustomerManagedInExchangeOnline`
      info	[Changelog] - New enum type `DomainsProvisioningState` with values `DomainsProvisioningStateCanceled`, `DomainsProvisioningStateCreating`, `DomainsProvisioningStateDeleting`, `DomainsProvisioningStateFailed`, `DomainsProvisioningStateMoving`, `DomainsProvisioningStateRunning`, `DomainsProvisioningStateSucceeded`, `DomainsProvisioningStateUnknown`, `DomainsProvisioningStateUpdating`
      info	[Changelog] - New enum type `EmailServicesProvisioningState` with values `EmailServicesProvisioningStateCanceled`, `EmailServicesProvisioningStateCreating`, `EmailServicesProvisioningStateDeleting`, `EmailServicesProvisioningStateFailed`, `EmailServicesProvisioningStateMoving`, `EmailServicesProvisioningStateRunning`, `EmailServicesProvisioningStateSucceeded`, `EmailServicesProvisioningStateUnknown`, `EmailServicesProvisioningStateUpdating`
      info	[Changelog] - New enum type `UserEngagementTracking` with values `UserEngagementTrackingDisabled`, `UserEngagementTrackingEnabled`
      info	[Changelog] - New enum type `VerificationStatus` with values `VerificationStatusCancellationRequested`, `VerificationStatusNotStarted`, `VerificationStatusVerificationFailed`, `VerificationStatusVerificationInProgress`, `VerificationStatusVerificationRequested`, `VerificationStatusVerified`
      info	[Changelog] - New enum type `VerificationType` with values `VerificationTypeDKIM`, `VerificationTypeDKIM2`, `VerificationTypeDMARC`, `VerificationTypeDomain`, `VerificationTypeSPF`
      info	[Changelog] - New function `NewClientFactory(string, azcore.TokenCredential, *arm.ClientOptions) (*ClientFactory, error)`
      info	[Changelog] - New function `*ClientFactory.NewDomainsClient() *DomainsClient`
      info	[Changelog] - New function `*ClientFactory.NewEmailServicesClient() *EmailServicesClient`
      info	[Changelog] - New function `*ClientFactory.NewOperationsClient() *OperationsClient`
      info	[Changelog] - New function `*ClientFactory.NewSenderUsernamesClient() *SenderUsernamesClient`
      info	[Changelog] - New function `*ClientFactory.NewServicesClient() *ServicesClient`
      info	[Changelog] - New function `NewDomainsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DomainsClient, error)`
      info	[Changelog] - New function `*DomainsClient.BeginCancelVerification(context.Context, string, string, string, VerificationParameter, *DomainsClientBeginCancelVerificationOptions) (*runtime.Poller[DomainsClientCancelVerificationResponse], error)`
      info	[Changelog] - New function `*DomainsClient.BeginCreateOrUpdate(context.Context, string, string, string, DomainResource, *DomainsClientBeginCreateOrUpdateOptions) (*runtime.Poller[DomainsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*DomainsClient.BeginDelete(context.Context, string, string, string, *DomainsClientBeginDeleteOptions) (*runtime.Poller[DomainsClientDeleteResponse], error)`
      info	[Changelog] - New function `*DomainsClient.Get(context.Context, string, string, string, *DomainsClientGetOptions) (DomainsClientGetResponse, error)`
      info	[Changelog] - New function `*DomainsClient.BeginInitiateVerification(context.Context, string, string, string, VerificationParameter, *DomainsClientBeginInitiateVerificationOptions) (*runtime.Poller[DomainsClientInitiateVerificationResponse], error)`
      info	[Changelog] - New function `*DomainsClient.NewListByEmailServiceResourcePager(string, string, *DomainsClientListByEmailServiceResourceOptions) *runtime.Pager[DomainsClientListByEmailServiceResourceResponse]`
      info	[Changelog] - New function `*DomainsClient.BeginUpdate(context.Context, string, string, string, UpdateDomainRequestParameters, *DomainsClientBeginUpdateOptions) (*runtime.Poller[DomainsClientUpdateResponse], error)`
      info	[Changelog] - New function `NewEmailServicesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*EmailServicesClient, error)`
      info	[Changelog] - New function `*EmailServicesClient.BeginCreateOrUpdate(context.Context, string, string, EmailServiceResource, *EmailServicesClientBeginCreateOrUpdateOptions) (*runtime.Poller[EmailServicesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*EmailServicesClient.BeginDelete(context.Context, string, string, *EmailServicesClientBeginDeleteOptions) (*runtime.Poller[EmailServicesClientDeleteResponse], error)`
      info	[Changelog] - New function `*EmailServicesClient.Get(context.Context, string, string, *EmailServicesClientGetOptions) (EmailServicesClientGetResponse, error)`
      info	[Changelog] - New function `*EmailServicesClient.NewListByResourceGroupPager(string, *EmailServicesClientListByResourceGroupOptions) *runtime.Pager[EmailServicesClientListByResourceGroupResponse]`
      info	[Changelog] - New function `*EmailServicesClient.NewListBySubscriptionPager(*EmailServicesClientListBySubscriptionOptions) *runtime.Pager[EmailServicesClientListBySubscriptionResponse]`
      info	[Changelog] - New function `*EmailServicesClient.ListVerifiedExchangeOnlineDomains(context.Context, *EmailServicesClientListVerifiedExchangeOnlineDomainsOptions) (EmailServicesClientListVerifiedExchangeOnlineDomainsResponse, error)`
      info	[Changelog] - New function `*EmailServicesClient.BeginUpdate(context.Context, string, string, EmailServiceResourceUpdate, *EmailServicesClientBeginUpdateOptions) (*runtime.Poller[EmailServicesClientUpdateResponse], error)`
      info	[Changelog] - New function `NewSenderUsernamesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SenderUsernamesClient, error)`
      info	[Changelog] - New function `*SenderUsernamesClient.CreateOrUpdate(context.Context, string, string, string, string, SenderUsernameResource, *SenderUsernamesClientCreateOrUpdateOptions) (SenderUsernamesClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*SenderUsernamesClient.Delete(context.Context, string, string, string, string, *SenderUsernamesClientDeleteOptions) (SenderUsernamesClientDeleteResponse, error)`
      info	[Changelog] - New function `*SenderUsernamesClient.Get(context.Context, string, string, string, string, *SenderUsernamesClientGetOptions) (SenderUsernamesClientGetResponse, error)`
      info	[Changelog] - New function `*SenderUsernamesClient.NewListByDomainsPager(string, string, string, *SenderUsernamesClientListByDomainsOptions) *runtime.Pager[SenderUsernamesClientListByDomainsResponse]`
      info	[Changelog] - New function `NewServicesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServicesClient, error)`
      info	[Changelog] - New function `*ServicesClient.CheckNameAvailability(context.Context, NameAvailabilityParameters, *ServicesClientCheckNameAvailabilityOptions) (ServicesClientCheckNameAvailabilityResponse, error)`
      info	[Changelog] - New function `*ServicesClient.BeginCreateOrUpdate(context.Context, string, string, ServiceResource, *ServicesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ServicesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ServicesClient.BeginDelete(context.Context, string, string, *ServicesClientBeginDeleteOptions) (*runtime.Poller[ServicesClientDeleteResponse], error)`
      info	[Changelog] - New function `*ServicesClient.Get(context.Context, string, string, *ServicesClientGetOptions) (ServicesClientGetResponse, error)`
      info	[Changelog] - New function `*ServicesClient.LinkNotificationHub(context.Context, string, string, *ServicesClientLinkNotificationHubOptions) (ServicesClientLinkNotificationHubResponse, error)`
      info	[Changelog] - New function `*ServicesClient.NewListByResourceGroupPager(string, *ServicesClientListByResourceGroupOptions) *runtime.Pager[ServicesClientListByResourceGroupResponse]`
      info	[Changelog] - New function `*ServicesClient.NewListBySubscriptionPager(*ServicesClientListBySubscriptionOptions) *runtime.Pager[ServicesClientListBySubscriptionResponse]`
      info	[Changelog] - New function `*ServicesClient.ListKeys(context.Context, string, string, *ServicesClientListKeysOptions) (ServicesClientListKeysResponse, error)`
      info	[Changelog] - New function `*ServicesClient.RegenerateKey(context.Context, string, string, RegenerateKeyParameters, *ServicesClientRegenerateKeyOptions) (ServicesClientRegenerateKeyResponse, error)`
      info	[Changelog] - New function `*ServicesClient.Update(context.Context, string, string, ServiceResourceUpdate, *ServicesClientUpdateOptions) (ServicesClientUpdateResponse, error)`
      info	[Changelog] - New struct `CheckNameAvailabilityRequest`
      info	[Changelog] - New struct `CheckNameAvailabilityResponse`
      info	[Changelog] - New struct `ClientFactory`
      info	[Changelog] - New struct `DNSRecord`
      info	[Changelog] - New struct `DomainProperties`
      info	[Changelog] - New struct `DomainPropertiesVerificationRecords`
      info	[Changelog] - New struct `DomainPropertiesVerificationStates`
      info	[Changelog] - New struct `DomainResource`
      info	[Changelog] - New struct `DomainResourceList`
      info	[Changelog] - New struct `EmailServiceProperties`
      info	[Changelog] - New struct `EmailServiceResource`
      info	[Changelog] - New struct `EmailServiceResourceList`
      info	[Changelog] - New struct `EmailServiceResourceUpdate`
      info	[Changelog] - New struct `ProxyResource`
      info	[Changelog] - New struct `SenderUsernameProperties`
      info	[Changelog] - New struct `SenderUsernameResource`
      info	[Changelog] - New struct `SenderUsernameResourceCollection`
      info	[Changelog] - New struct `ServiceResourceUpdate`
      info	[Changelog] - New struct `ServiceUpdateProperties`
      info	[Changelog] - New struct `TrackedResource`
      info	[Changelog] - New struct `UpdateDomainProperties`
      info	[Changelog] - New struct `UpdateDomainRequestParameters`
      info	[Changelog] - New struct `VerificationParameter`
      info	[Changelog] - New struct `VerificationStatusRecord`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `LinkedDomains` in struct `ServiceProperties`
      info	[Changelog]
      info	[Changelog] Total 18 breaking change(s), 141 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b396f5a. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-communication [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added operation group CommunicationServices
      info	[Changelog]   - Added operation group Domains
      info	[Changelog]   - Added operation group EmailServices
      info	[Changelog]   - Added operation group SenderUsernames
      info	[Changelog]   - Added Interface CheckNameAvailabilityRequest
      info	[Changelog]   - Added Interface CheckNameAvailabilityResponse
      info	[Changelog]   - Added Interface CommunicationServiceResource
      info	[Changelog]   - Added Interface CommunicationServiceResourceUpdate
      info	[Changelog]   - Added Interface CommunicationServicesCheckNameAvailabilityOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesCreateOrUpdateHeaders
      info	[Changelog]   - Added Interface CommunicationServicesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesDeleteHeaders
      info	[Changelog]   - Added Interface CommunicationServicesDeleteOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesGetOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesLinkNotificationHubOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesListByResourceGroupNextOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesListByResourceGroupOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesListBySubscriptionNextOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesListBySubscriptionOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesListKeysOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesRegenerateKeyOptionalParams
      info	[Changelog]   - Added Interface CommunicationServicesUpdateOptionalParams
      info	[Changelog]   - Added Interface DnsRecord
      info	[Changelog]   - Added Interface DomainPropertiesVerificationRecords
      info	[Changelog]   - Added Interface DomainPropertiesVerificationStates
      info	[Changelog]   - Added Interface DomainResource
      info	[Changelog]   - Added Interface DomainResourceList
      info	[Changelog]   - Added Interface DomainsCancelVerificationHeaders
      info	[Changelog]   - Added Interface DomainsCancelVerificationOptionalParams
      info	[Changelog]   - Added Interface DomainsCreateOrUpdateHeaders
      info	[Changelog]   - Added Interface DomainsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface DomainsDeleteHeaders
      info	[Changelog]   - Added Interface DomainsDeleteOptionalParams
      info	[Changelog]   - Added Interface DomainsGetOptionalParams
      info	[Changelog]   - Added Interface DomainsInitiateVerificationHeaders
      info	[Changelog]   - Added Interface DomainsInitiateVerificationOptionalParams
      info	[Changelog]   - Added Interface DomainsListByEmailServiceResourceNextOptionalParams
      info	[Changelog]   - Added Interface DomainsListByEmailServiceResourceOptionalParams
      info	[Changelog]   - Added Interface DomainsUpdateHeaders
      info	[Changelog]   - Added Interface DomainsUpdateOptionalParams
      info	[Changelog]   - Added Interface EmailServiceResource
      info	[Changelog]   - Added Interface EmailServiceResourceList
      info	[Changelog]   - Added Interface EmailServiceResourceUpdate
      info	[Changelog]   - Added Interface EmailServicesCreateOrUpdateHeaders
      info	[Changelog]   - Added Interface EmailServicesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface EmailServicesDeleteHeaders
      info	[Changelog]   - Added Interface EmailServicesDeleteOptionalParams
      info	[Changelog]   - Added Interface EmailServicesGetOptionalParams
      info	[Changelog]   - Added Interface EmailServicesListByResourceGroupNextOptionalParams
      info	[Changelog]   - Added Interface EmailServicesListByResourceGroupOptionalParams
      info	[Changelog]   - Added Interface EmailServicesListBySubscriptionNextOptionalParams
      info	[Changelog]   - Added Interface EmailServicesListBySubscriptionOptionalParams
      info	[Changelog]   - Added Interface EmailServicesListVerifiedExchangeOnlineDomainsOptionalParams
      info	[Changelog]   - Added Interface EmailServicesUpdateHeaders
      info	[Changelog]   - Added Interface EmailServicesUpdateOptionalParams
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface SenderUsernameResource
      info	[Changelog]   - Added Interface SenderUsernameResourceCollection
      info	[Changelog]   - Added Interface SenderUsernamesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface SenderUsernamesDeleteOptionalParams
      info	[Changelog]   - Added Interface SenderUsernamesGetOptionalParams
      info	[Changelog]   - Added Interface SenderUsernamesListByDomainsNextOptionalParams
      info	[Changelog]   - Added Interface SenderUsernamesListByDomainsOptionalParams
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface UpdateDomainRequestParameters
      info	[Changelog]   - Added Interface VerificationParameter
      info	[Changelog]   - Added Interface VerificationStatusRecord
      info	[Changelog]   - Added Type Alias CheckNameAvailabilityReason
      info	[Changelog]   - Added Type Alias CommunicationServicesCheckNameAvailabilityResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesGetResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesLinkNotificationHubResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesListKeysResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesProvisioningState
      info	[Changelog]   - Added Type Alias CommunicationServicesRegenerateKeyResponse
      info	[Changelog]   - Added Type Alias CommunicationServicesUpdateResponse
      info	[Changelog]   - Added Type Alias DomainManagement
      info	[Changelog]   - Added Type Alias DomainsCancelVerificationResponse
      info	[Changelog]   - Added Type Alias DomainsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias DomainsGetResponse
      info	[Changelog]   - Added Type Alias DomainsInitiateVerificationResponse
      info	[Changelog]   - Added Type Alias DomainsListByEmailServiceResourceNextResponse
      info	[Changelog]   - Added Type Alias DomainsListByEmailServiceResourceResponse
      info	[Changelog]   - Added Type Alias DomainsProvisioningState
      info	[Changelog]   - Added Type Alias DomainsUpdateResponse
      info	[Changelog]   - Added Type Alias EmailServicesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias EmailServicesGetResponse
      info	[Changelog]   - Added Type Alias EmailServicesListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias EmailServicesListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias EmailServicesListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias EmailServicesListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias EmailServicesListVerifiedExchangeOnlineDomainsResponse
      info	[Changelog]   - Added Type Alias EmailServicesProvisioningState
      info	[Changelog]   - Added Type Alias EmailServicesUpdateResponse
      info	[Changelog]   - Added Type Alias SenderUsernamesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SenderUsernamesGetResponse
      info	[Changelog]   - Added Type Alias SenderUsernamesListByDomainsNextResponse
      info	[Changelog]   - Added Type Alias SenderUsernamesListByDomainsResponse
      info	[Changelog]   - Added Type Alias UserEngagementTracking
      info	[Changelog]   - Added Type Alias VerificationStatus
      info	[Changelog]   - Added Type Alias VerificationType
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Added Enum KnownCheckNameAvailabilityReason
      info	[Changelog]   - Added Enum KnownCommunicationServicesProvisioningState
      info	[Changelog]   - Added Enum KnownDomainManagement
      info	[Changelog]   - Added Enum KnownDomainsProvisioningState
      info	[Changelog]   - Added Enum KnownEmailServicesProvisioningState
      info	[Changelog]   - Added Enum KnownUserEngagementTracking
      info	[Changelog]   - Added Enum KnownVerificationStatus
      info	[Changelog]   - Added Enum KnownVerificationType
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group CommunicationService
      info	[Changelog]   - Class CommunicationServiceManagementClient no longer has parameter communicationService
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b396f5a. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.communication.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app-test
    Copy link

    openapi-pipeline-app-test bot commented Nov 8, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/communication/armcommunication https://apiviewstaging.azurewebsites.net/Assemblies/Review/626d59c7072c403ab5c33eefd4398c67
    .Net Azure.ResourceManager.Communication There is no API change compared with the previous version
    Java azure-resourcemanager-communication There is no API change compared with the previous version
    JavaScript @azure/arm-communication There is no API change compared with the previous version

    @openapi-pipeline-app-test
    Copy link

    openapi-pipeline-app-test bot commented Nov 8, 2022

    Swagger Validation Report

    ️❌BreakingChange: 22 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    CommunicationServices.json 2023-03-31(b396f5a) 2023-03-31(main)
    servicebus.json 2021-05(b396f5a) 2021-05(main)
    servicefabricmesh.json 2018-07-01-preview(b396f5a) 2018-07-01-preview(main)
    servicefabricmesh.json 2018-09-01-preview(b396f5a) 2018-09-01-preview(main)
    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L133:9
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L133:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L279:9
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L279:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L332:9
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L332:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L376:9
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L376:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L448:9
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L448:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L504:9
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L504:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L550:9
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L550:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L828:5
    Old: Microsoft.Communication/stable/2023-03-31/CommunicationServices.json#L828:5
    1041 - AddedPropertyInResponse The new version has a new property 'properties' in response that was not found in the old version.
    New: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L1621:7
    Old: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L1621:7
    1041 - AddedPropertyInResponse The new version has a new property 'properties' in response that was not found in the old version.
    New: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1878:7
    Old: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1878:7
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L472:9
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L472:9
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L93:5
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L93:5
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L151:11
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L151:11
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L712:9
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L712:9
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L786:9
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L786:9
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1090:9
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1090:9
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1157:9
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1157:9
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1403:9
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1403:9
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1469:9
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L1469:9
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L328:5
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L328:5
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L347:5
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L347:5
    1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L430:5
    Old: Microsoft.ServiceBus/stable/2021-05/servicebus.json#L430:5
    ️⚠️Breaking Change(Cross-Version): 7 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    containerInstance.json 2023-02-01-preview(b396f5a) 2022-09-01(main)
    containerInstance.json 2023-02-01-preview(b396f5a) 2022-10-01-preview(main)

    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Confidential' from the old version.
    New: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1457:13
    Old: Microsoft.ContainerInstance/preview/2022-10-01-preview/containerInstance.json#L1448:13
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Confidential' from the old version.
    New: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1457:13
    Old: Microsoft.ContainerInstance/preview/2022-10-01-preview/containerInstance.json#L1448:13
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Confidential' from the old version.
    New: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L2229:5
    Old: Microsoft.ContainerInstance/preview/2022-10-01-preview/containerInstance.json#L2236:5
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'confidentialComputeProperties' renamed or removed?
    New: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1335:11
    Old: Microsoft.ContainerInstance/preview/2022-10-01-preview/containerInstance.json#L1344:11
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'priority' renamed or removed?
    New: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1335:11
    Old: Microsoft.ContainerInstance/preview/2022-10-01-preview/containerInstance.json#L1344:11
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'confidentialComputeProperties' renamed or removed?
    New: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1335:11
    Old: Microsoft.ContainerInstance/preview/2022-10-01-preview/containerInstance.json#L1344:11
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'priority' renamed or removed?
    New: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1335:11
    Old: Microsoft.ContainerInstance/preview/2022-10-01-preview/containerInstance.json#L1344:11
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-02 package-preview-2023-02(b396f5a) default(main)
    package-2023-03 package-2023-03(b396f5a) package-2023-03(main)
    package-2021-05 package-2021-05(b396f5a) package-2021-05(main)
    package-2018-09-01-preview package-2018-09-01-preview(b396f5a) package-2018-09-01-preview(main)
    package-2018-07-01-preview package-2018-07-01-preview(b396f5a) package-2018-07-01-preview(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L1638
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1895


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L113
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L155
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L237
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L237
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L237
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L237
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L262
    DeleteResponseBodyEmpty The delete response body must be empty.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L288
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L292
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L308
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L309
    PostOperationAsyncResponseValidation An async POST operation must return 202.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L332
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L346
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L383
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L384
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L408
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.ContainerInstance/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L444
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L499
    ResourceNameRestriction The resource name parameter 'containerName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L499
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L559
    ResourceNameRestriction The resource name parameter 'containerName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L559
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L615
    ResourceNameRestriction The resource name parameter 'containerName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L615
    ResourceNameRestriction The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L742
    ResourceNameRestriction The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L778
    ResourceNameRestriction The resource name parameter 'subnetName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L778
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L778
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L779
    LongRunningResponseStatusCode A 'delete' operation 'SubnetServiceAssociationLink_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L779
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L809
    ️️✔️~[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ModelValidation: 5 Errors, 0 Warnings failed [Detail]
    Rule Message
    ENUM_CASE_MISMATCH Enum does not match case for: linux
    Url: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L2033:19
    ExampleUrl: preview/2018-07-01-preview/examples/ApplicationCreateOrUpdate.json#L9:39
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L1357:35
    ExampleUrl: preview/2018-07-01-preview/examples/ServiceList.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L1357:35
    ExampleUrl: preview/2018-07-01-preview/examples/ServiceGet.json#L11:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Operations_List.
    Url: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L479:14
    INVALID_TYPE Expected type integer but found type string
    Url: Microsoft.ServiceFabricMesh/preview/2018-07-01-preview/servicefabricmesh.json#L2106:23
    ExampleUrl: preview/2018-07-01-preview/examples/NetworkCreateOrUpdate.json#L9:35
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️~[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️~[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    Posted by Swagger Pipeline | How to fix these errors?

    conniey and others added 4 commits March 28, 2023 17:34
    … version preview/2023-02-01-preview (Azure#23221)
    
    * Adds base for updating Microsoft.ContainerInstance from version stable/2022-09-01 to version 2023-02-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * added property
    
    * added sample request and responses
    
    * integer format
    
    * read only property
    
    * read only fix
    
    * custom word
    
    * changed boolean to enum
    
    * changed boolean to enum in examples
    
    * x-ms-enum
    * added properties property for operation object
    
    * updated older api version as well
    
    * prettier fix
    
    * use full description for properties object
    
    * remove 'type'
    
    * use correct property name
    @workflow-bot-test
    Copy link

    Hi @ruowan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @workflow-bot-test
    Copy link

    Hi @ruowan, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @workflow-bot-test
    Copy link

    Hi, @ruowan, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @workflow-bot-test
    Copy link

    Hi @ruowan This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main.

    @mikeharder mikeharder merged commit b396f5a into test-repo-billy:main Mar 31, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment