Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add import to module generation #2537

Merged
merged 1 commit into from
May 10, 2024

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented May 10, 2024

What does this PR do?

This PR adds a missing import for "fmt" in the template that generates the module Go file.

Why is it important?

The modules are generated, but the process fails because the code does not compile: missing import.

Related issues

Follow-ups

There is no need to create a patch release, as users of the module generation tool will use it from the source code.

@mdelapenya mdelapenya requested a review from a team as a code owner May 10, 2024 05:50
@mdelapenya mdelapenya added the bug An issue with the library label May 10, 2024
@mdelapenya mdelapenya self-assigned this May 10, 2024
Copy link

netlify bot commented May 10, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 69f3c5d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/663db5948155500008327cac
😎 Deploy Preview https://deploy-preview-2537--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member Author

Merging, as the tests for the modulegen already passed.

@mdelapenya mdelapenya merged commit df8c549 into testcontainers:main May 10, 2024
19 of 21 checks passed
@mdelapenya mdelapenya deleted the fix-modulegen branch May 20, 2024 12:57
mdelapenya added a commit to bearrito/testcontainers-go that referenced this pull request Jun 11, 2024
* main: (48 commits)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
  Handle error properly during port forwarding initialization. (testcontainers#2550)
  chore: pin vearch version (testcontainers#2568)
  feat: add vearch module (testcontainers#2560)
  chore: run tests against latest Docker engine, nightly (testcontainers#2566)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.0.7 (testcontainers#2562)
  Fix network accessor for port-forwarding feature (testcontainers#2551)
  --- (testcontainers#2549)
  fix: update search bar eval in mkdocs (testcontainers#2547)
  docs: improve contributing docs for code snippets (testcontainers#2546)
  chore: use a virtualenv for working with the docs site (testcontainers#2545)
  docs: document test session semantics (testcontainers#2544)
  feat(ryuk): allow to configure ryuk timeouts using env variables (testcontainers#2541)
  docs: fix CircleCI docs (testcontainers#2539)
  fix: add import to module generation (testcontainers#2537)
  chore: prepare for next minor development cycle (0.32.0)
  chore: use new version (v0.31.0) in modules and examples
  feat(mongodb): add replica set support via opts (testcontainers#2469)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant