fix(elasticsearch): wait for #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Aug 12, 2024
mdelapenya
reviewed
Aug 12, 2024
Merged
This is actually a bug, I missed the circular dependency between the ready and wait conditions. There's two options:
|
stevenh
force-pushed
the
fix/elasticsearch-wait
branch
2 times, most recently
from
47902f6
to
0753e11
Compare
stevenh
force-pushed
the
fix/elasticsearch-wait
branch
from
0753e11
to
7eeb3a5
Compare
|
@mdelapenya rebased on top of the new |
mdelapenya
reviewed
Sep 26, 2024
mdelapenya
reviewed
Sep 26, 2024
mdelapenya
previously approved these changes
Sep 26, 2024
Wait for the HTTP port to be available to prevent random failures when the container isn't fully started and returns 503 errors.
stevenh
force-pushed
the
fix/elasticsearch-wait
branch
from
5b52d34
to
b04d5c9
Compare
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 27, 2024
* main: fix(elasticsearch): wait for (testcontainers#2724)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 27, 2024
* main: fix(redpanda): wait for (testcontainers#2794) fix(elasticsearch): wait for (testcontainers#2724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the HTTP port to be available to prevent random failures when the container isn't fully started and returns 503 errors.