Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowserWebDriverContainer: Timeout in containerIsStarted #4469

Closed
Flugtiger opened this issue Sep 20, 2021 · 1 comment · Fixed by #4470
Closed

BrowserWebDriverContainer: Timeout in containerIsStarted #4469

Flugtiger opened this issue Sep 20, 2021 · 1 comment · Fixed by #4470

Comments

@Flugtiger
Copy link
Contributor

We get a timeout in BrowserWebDriverContainer#containerIsStarted. It seems the fix for #373 is broken. The inner getWithTimout contains a double nested lambda so the timeout is only applied to the outer lambda which returns immediatly. So when "new RemoteWebDriver" gets stuck in the race condition mentioned in #373, retryUntilSuccess throws when it reaches its own timeout in the first try.

Flugtiger added a commit to Flugtiger/testcontainers-java that referenced this issue Sep 20, 2021
This fixes testcontainers#4469, getWithTimeout did only apply to the outer lambda, which returned immediately (the inner lambda). Instead wrap getWithTimeout itself inside a lambda.
@rnorth
Copy link
Member

rnorth commented Sep 23, 2021

@Flugtiger is it possible that you're encountering this? SeleniumHQ/docker-selenium#1346

#4315 is a workaround which we should be releasing soon - I'm not sure whether this has been fixed on the selenium side as well.

kiview pushed a commit that referenced this issue Oct 22, 2021
This fixes #4469, `getWithTimeou`t did only apply to the outer lambda, which returned immediately (the inner lambda). Instead, wrap getWithTimeout itself inside a lambda.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants