Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky WaitAllStrategyTest#appliesOuterTimeout test #731

Merged
merged 1 commit into from
Jun 8, 2018
Merged

fix flaky WaitAllStrategyTest#appliesOuterTimeout test #731

merged 1 commit into from
Jun 8, 2018

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Jun 5, 2018

No description provided.

@bsideup bsideup added this to the next milestone Jun 5, 2018
@bsideup bsideup requested review from rnorth and kiview June 5, 2018 08:58
kiview
kiview approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the timeout at

testcontainers-java/core/src/test/java/org/testcontainers/containers/wait/WaitAllStrategyTest.java

Line 58 in 90cdd1d

.withStartupTimeout(Duration.ofMillis(10));
?

@bsideup
Copy link
Member Author

bsideup commented Jun 5, 2018

@kiview no, why? :)

@kiview
Copy link
Member

kiview commented Jun 5, 2018

So the flaky behaviour was, because of both timeouts being 10 ms at first?

@bsideup
Copy link
Member Author

bsideup commented Jun 5, 2018

@kiview rather too low outer timeout (20ms)

@bsideup bsideup mentioned this pull request Jun 5, 2018
Merged
@bsideup bsideup merged commit fc2f169 into master Jun 8, 2018
@bsideup bsideup deleted the fix_flaky_test branch June 8, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bsideup @kiview