Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TGS5 (.NET 6 update) #1383

Merged
merged 10 commits into from
Sep 17, 2022
Merged

TGS5 (.NET 6 update) #1383

merged 10 commits into from
Sep 17, 2022

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Sep 12, 2022 •
edited
Loading

🆑
The .NET version used to run TGS has been upgraded from 3.1 to 6.0. You MUST install the ASP.NET 6.0 runtime into whatever system you are running TGS on prior to using the built in updater. Simply pulling the latest docker image will suffice for docker users.
Docker image debian distro updated from buster to bullseye-slim.
The console runner will not be updated to use .NET 6 without a full reinstall of the TGS binaries.
Improved memory usage when downloading BYOND binaries.
/:cl:

  • Use SDK code analyzers
  • Updated nuget packages (excluding LibGit2Sharp)
  • Removed main app Dockerfile (was intended for debugging, never used)
  • Updated CI

Closes #1149

@Cyberboss Cyberboss added Client Issue with the .NET client library Fix Fixes incorrect functionality CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION Documentation Documentation updates Code Improvement Brush up on code standards Performance Improves server performance Logging Adding, removing, or lack of informational log output DreamDaemon Downtime (optional) Changes that require DreamDaemon to be shutdown to apply but are not required Runner: Console Issue related to the console host watchdog Tools Docker Rebuild Requires a rebuild of lower docker layers meaning a full recreation of the containeris necessary Docker Related to the Docker image labels Sep 12, 2022
@Cyberboss Cyberboss added this to the v5.0.0 milestone Sep 12, 2022
@Cyberboss Cyberboss self-assigned this Sep 12, 2022
@codecov

This comment was marked as outdated.

Sign in to view
@Cyberboss
Update to .net-6.0. Fix errors and warnings
6960525 
- Address various IDE messages
- Additional logging
- Do not access DB in Watchdog's actual Dispose
- Fix issue with legacy behaviour in PGSQL
- Remove obsolete dotnet workaround
- Update to v3 actions checkout/upload-artifact/download-artifact
@Cyberboss
Copy link
Member Author

This is only being held up by CodeCov. Tempted to change providers

@Cyberboss
Copy link
Member Author

Fuck it

@Cyberboss Cyberboss merged commit fddbd66 into dev Sep 17, 2022
@Cyberboss Cyberboss deleted the V5-NetOnly branch September 17, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cyberboss Cyberboss

Labels
CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION Client Issue with the .NET client library Code Improvement Brush up on code standards Docker Rebuild Requires a rebuild of lower docker layers meaning a full recreation of the containeris necessary Docker Related to the Docker image Documentation Documentation updates DreamDaemon Downtime (optional) Changes that require DreamDaemon to be shutdown to apply but are not required Fix Fixes incorrect functionality Logging Adding, removing, or lack of informational log output Performance Improves server performance Runner: Console Issue related to the console host watchdog
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Port server runtime to .NET 6 LTS
2 participants
@Cyberboss @tgstation-server