Hotfix for UART-16550 driver and Arty-Managed example design. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Hotfix for UART-16550 driver and Arty-Managed example design.
ooterness
changed the title
markubiak
reviewed
Oct 22, 2021
| @@ -193,5 +194,18 @@ namespace satcat5 { | |||
| enum {SATCAT5_LITTLE_ENDIAN = 0x03020100ul, SATCAT5_BIG_ENDIAN = 0x00010203ul}; | |||
| constexpr union {u8 bytes[4]; u32 value;} HOST_ORDER_CANARY = {{0,1,2,3}}; | |||
| inline u32 HOST_BYTE_ORDER() {return HOST_ORDER_CANARY.value;} | |||
|
|
|||
| // In-place byte-for-byte format conversion, aka "type-punning". | |||
| template<typename T1, typename T2> inline T2 reinterpret(T1 x) | |||
There was a problem hiding this comment.
I've not seen this before, but the reasoning for it (instead of using a traditional cast) checks out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for UART-16550 driver and Arty-Managed example design.
Description
Motivation and Context
This hotfix corrects a major bug in the Arty-Managed example design that was discovered just after the v2.0.0 release.
It also incorporates some incidental improvements, including additional data-types for the Readable and Writeable API.
How Has This Been Tested?
Jenkins build passes all unit tests. Arty-Managed bitfile has been loaded on hardware and tested manually.
Types of changes
Checklist: