Jk bm estimated next date

[borjaMarti]

Description

For this feature we installed the @the-collab-lab/shopping-list-utils dependency so we could import the calculateEstimate function, which we use to generate a new dateNextPurchased each time an item is marked as purchased.

Related Issue

Closes #11

Acceptance Criteria

• When the user purchases an item, the item’s dateNextPurchased property is calculated using the calculateEstimate function and saved to the Firestore database
  • dateNextPurchased is saved as a date, not a number
• A getDaysBetweenDates function is exported from utils/dates.js and imported into api/firebase.js
  • This function takes two JavaScript Dates and return the number of days that have passed between them

Type of Changes

	Type
✓	✨ New database feature
✓	🔗 Update dependencies

Updates

Before

After

Testing Steps / QA Criteria

• Run git pull origin jk-bm-estimated-next-date to pull commit.
• Run npm install to update dependencies.
• Create an item.
• Check Firestore's document dateNextPurchased.
• Mark item as purchased.
• Check Firestore's document for updated dateNextPurchased.

[github-actions]

Visit the preview URL for this PR (updated for commit d5505f7):

https://tcl-71-smart-shopping-list--pr30-jk-bm-estimated-next-f2fkai6w.web.app

_{(expires Thu, 14 Mar 2024 10:53:14 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4}

[ocsiddisco]

Thanks for your work!
I have a question regarding lines 200-202: In place of undefined, I would have added a calculation getDaysBetweenDates(dateNextPurchased, dateCreated), to get the initial count of days before the first purchase. What is the reason behind setting it to undefined?
@borjaMarti @BikeMouse

[borjaMarti]

Hey Céline!

You are totally right, we updated the implementation to take into account that period instead of passing undefined as the default.

Thanks for the feedback! 😄

[vivitt]

Nice job! I think the feature works as expected, and I appreciate that you documented the new function in dates.js.

I'd also like to comment about setting prevEstimate in firebase.js to the value that the user submitted when creating the item as daysUntilNextPurchase:

	const prevEstimate = dateLastPurchased
		? getDaysBetweenDates(dateNextPurchased, dateLastPurchased)
		: getDaysBetweenDates(dateNextPurchased, dateCreated)

Is there a specific reason for keeping it as undefined if dateLastPurchased is null?

🙌🏽 Thanks!

[borjaMarti]

Nice job! I think the feature works as expected, and I appreciate that you documented the new function in dates.js.

I'd also like to comment about setting prevEstimate in firebase.js to the value that the user submitted when creating the item as daysUntilNextPurchase:

	const prevEstimate = dateLastPurchased
		? getDaysBetweenDates(dateNextPurchased, dateLastPurchased)
		: getDaysBetweenDates(dateNextPurchased, dateCreated)

Is there a specific reason for keeping it as undefined if dateLastPurchased is null?

🙌🏽 Thanks!

Hey Viviana!

I adressed this on the reply to Céline as well.

Thanks for the feedback! ^^

[ocsiddisco]

It works nicely! Thank you!

[llyorshch]

Good work! 👏