Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scroll horizontal #81

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix scroll horizontal #81

merged 1 commit into from
Jun 5, 2024

Conversation

ocsiddisco
Copy link
Collaborator

Description

This PR removes the horizontal scrolling that was present on the application, and on small screen, the menu is now on position fixed.

Type of Changes

Bug fix

Updates

Before

Screenshot 2024-05-15 113737

Screenshot 2024-05-15 113845

After

Screenshot 2024-05-15 112442

Screenshot 2024-05-15 112505

Testing Steps / QA Criteria

  • git checkout -b ce-fixScroll
  • git pull origin ce-fixScroll
  • run npm start to review the changes

@ocsiddisco ocsiddisco self-assigned this May 15, 2024
@ocsiddisco ocsiddisco marked this pull request as ready for review May 15, 2024 09:43
Copy link

Visit the preview URL for this PR (updated for commit 7e0306c):

https://tcl-71-smart-shopping-list--pr81-ce-fixscroll-u212wcdg.web.app

(expires Wed, 22 May 2024 09:44:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4

Copy link
Collaborator

@borjaMarti borjaMarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ocsiddisco! No horizontal scrolling found, thank you!! ^^

@ocsiddisco ocsiddisco merged commit 186763d into main Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants