Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bread ordering #4643

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Fix bread ordering #4643

merged 4 commits into from
Jul 6, 2020

Conversation

terax6669
Copy link
Contributor

Disable sorting on columns that are not sortable anyway.

Voyager does not support server-side sorting by relationship.

@emptynick emptynick self-assigned this Mar 10, 2020
emptynick
emptynick previously approved these changes Jul 6, 2020
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #4643 into 1.4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #4643   +/-   ##
=========================================
  Coverage     62.96%   62.96%           
  Complexity     1373     1373           
=========================================
  Files           194      194           
  Lines          4007     4007           
=========================================
  Hits           2523     2523           
  Misses         1484     1484           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294ff76...fc1d9fc. Read the comment docs.

@emptynick emptynick changed the base branch from 1.3 to 1.4 July 6, 2020 10:41
@emptynick emptynick dismissed their stale review July 6, 2020 10:41

The base branch was changed.

@terax6669
Copy link
Contributor Author

I'm currently using this fix in a project using 1.4.2 so it should be compatible with 1.4 as well

@emptynick
Copy link
Collaborator

Yeah there haven't been any changes related to this in 1.4

@emptynick emptynick merged commit 6063f09 into thedevdojo:1.4 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants