Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scope not working with withTrashed #5195

Merged

Conversation

MrCrayon
Copy link
Collaborator

More informations in the bug report but basically the model was being overriden by the query building with:

$model = $model->withTrashed();

Fixes #4963

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #5195 (5c8f19b) into 1.4 (1732bee) will decrease coverage by 0.00%.
The diff coverage is 30.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.4    #5195      +/-   ##
============================================
- Coverage     63.31%   63.31%   -0.01%     
  Complexity     1379     1379              
============================================
  Files           194      194              
  Lines          4070     4075       +5     
============================================
+ Hits           2577     2580       +3     
- Misses         1493     1495       +2     
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/VoyagerBaseController.php 57.69% <30.00%> (+0.02%) 143.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1732bee...5c8f19b. Read the comment docs.

@emptynick emptynick merged commit e0d3b00 into thedevdojo:1.4 Jan 28, 2021
@MrCrayon MrCrayon deleted the fix-scope-not-working-with-withtrashed branch February 11, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withTrashed() not working properly on show and edit
2 participants