-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fdi-service dependencies and build RPMs #11221
base: rpm/develop
Are you sure you want to change the base?
Conversation
The
I need to learn how to fix them as the |
I found a way how to build FDI without these meta-packages; maybe they won't be needed anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't commit the RPM files. We probably lack a .gitignore
line for that.
I would also prefer it if we created a proper gem for text interface and then package that. Right now https://github.com/theforeman/foreman-discovery-image has a root/share/ruby
with some code and this reflects the requirements that it needs. Not really easy to maintain IMHO.
I found a way to make this meta-package obsolete. I'll keep the PR open for now, and when the EL9 changes are approved, I will update it to remove the spec. |
packages/plugins/foreman-discovery-image-service/foreman-discovery-image-service.spec
Outdated
Show resolved
Hide resolved
f261315
to
384d054
Compare
Waiting for #11268 |
No description provided.