replace rm with embedded BSD coreutils rm #374
Conversation
andy5995
force-pushed
the
replace-rm
branch
8 times, most recently
from
832a95c
to
8d512c0
Compare
|
@DiegoMagdaleno I get errors when building on macos https://github.com/theimpossibleastronaut/rmw/actions/runs/4002064406/jobs/6868938665 Is BSDCoreUtils intended to run on macos or just on Linux? Also getting error on FreeBSD... https://github.com/theimpossibleastronaut/rmw/actions/runs/4002064406/jobs/6868938848#step:3:1462 |
|
It is intended to work on macOS, it looks like the issue is related to the definition of macOS guid and uid, I can try checking the error out As for FreeBSD, at least in the logs, I can't see the error, it just says "Bash exited with error code 1" I guess my workaround for the definitions of said functions (guid and uid) broke in some update after I stopped using macOS, I'll check it out. Update: This issue should be fixed (?) |
|
@andy5995 I did a quick commit, try to checkout if that fixes the issue. |
It did! Thanks! The errors from the FreeBSD build are in the txt file attached. 11 of them. |
|
For FreeBSD I am able to notice the issue, it looks like the compatibility library might need some changes when on FreeBSD. Due to my timezone and University I'll be checking FreeBSD issues tomorrow, once I setup a virtual machine. Thank for helping in diverse compatibility checks. |
|
Sure, there is no rush. Get some rest! I appreciate your help. |
|
@andy5995 I added some fixes for FreeBSD, can you please check if some errors are fixed? |
|
I pushed some more fixes, should fix some declaration issues.. |
|
@DiegoMagdaleno I just applied your second patch now. We'll see shortly if it works. Thanks! |
Working now! All builds completing and tests passing. :) |
|
Great! |
https://github.com/dcantrell/bsdutils The FreeBSD version from here seems like it's more updated.
No description provided.