Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update loadFry function #7

Merged
merged 4 commits into from
Jul 23, 2021
Merged

update loadFry function #7

merged 4 commits into from
Jul 23, 2021

Conversation

DongzeHE
Copy link
Collaborator

Hi @mikelove,

In alevin-fry 0.4.1, the meta_info.json is called quant.json as discussed at COMBINE-lab/alevin-fry#22 (comment) .

@mikelove mikelove merged commit 19124e4 into thelovelab:master Jul 23, 2021
@mikelove
Copy link
Collaborator

Thanks, pushing now to Bioc

@mikelove
Copy link
Collaborator

Oops with this pull I get a test error when running R CMD check

* checking tests ...
  Running ‘testthat.R’
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  > test_check("fishpond")
  ══ Skipped tests ═══════════════════════════════════════════════════════════════
  • empty test (5)

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error (test_loadFry.R:13:3): Reading in Alevin-fry USA count matrix works ───
  Error: argument "txt" is missing, with no default
  Backtrace:
      █
   1. └─fishpond::loadFry(fry.dir) test_loadFry.R:13:2
   2.   └─jsonlite::fromJSON(file = qfile)

  [ FAIL 1 | WARN 0 | SKIP 5 | PASS 18 ]
  Error: Test failures
  Execution halted

@mikelove
Copy link
Collaborator

mikelove commented Jul 23, 2021

I've removed the loadFry test temporarily, could you take a look and when you get test_file("tests/testthat/test_loadFry.R") and/or R CMD check passing re-PR?

@DongzeHE
Copy link
Collaborator Author

I realized that the error is caused by the discrepancy between rjson and JSONlite packages! It can be easily solved by changing line 55 from meta_info <- fromJSON(file = qfile) to meta_info <- fromJSON(txt = qfile). Sorry about the mistake, I will re-PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants