-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for primitive object wrappers (fixes #295) #296
Conversation
Hi @smares 👋 Thanks a lot for coming up with this PR 😊 First, code analysis now fails – you can see this when you run Second, the documentation should be updated as well. It's probably enough to have one sentence pointing out that it also works with the object wrappers, however it would be great if you could add this to the Last but not least, I wanted to ask if you would like to add yourself to the list of contributors in the |
When I run
That Not sure if this is caused by the previous line, but I can't seem to get rid of the Any idea what I am doing wrong? |
Updated readme to reflect the added support for primitive object wrappers. Updated package.json to include myself as contributor.
@smares Well, we do not currently support running So, thanks for the updates, I'll have a look at them, and get back to you as soon as possible 😊 |
@smares I've just added a few missing commas, and merged it now – will be live on npm in a few minutes. Thanks once again for all your work 😊 |
Added support for primitive object wrappers (fixes #295)