Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a function named 'card' #5

Merged
merged 4 commits into from
Mar 13, 2022
Merged

Added a function named 'card' #5

merged 4 commits into from
Mar 13, 2022

Conversation

GokulramGHV
Copy link
Contributor

  • Changed few terms used in the docstrings.
  • Added a function named 'card' that simulates picking N cards randomly from a deck of 52 cards.
  • Added the 'card' function to work with the 'combi' function.

@GokulramGHV GokulramGHV marked this pull request as draft March 12, 2022 15:58
@GokulramGHV GokulramGHV marked this pull request as ready for review March 12, 2022 15:59
@thenithinbalaji thenithinbalaji self-requested a review March 12, 2022 16:01
thenithinbalaji
thenithinbalaji requested changes Mar 12, 2022
View reviewed changes
Copy link
Owner

@thenithinbalaji thenithinbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add .gitignore
  • Implement changes mentioned in comments

@thenithinbalaji thenithinbalaji added the enhancement New feature or request label Mar 12, 2022
@thenithinbalaji
Copy link
Owner

Adding my own to remember list,
[x] Add cards in readme.md
[x] Add cards in readme.rst

thenithinbalaji
thenithinbalaji reviewed Mar 12, 2022
View reviewed changes
Copy link
Owner

@thenithinbalaji thenithinbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thenithinbalaji
thenithinbalaji approved these changes Mar 12, 2022
View reviewed changes
Copy link
Owner

@thenithinbalaji thenithinbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thenithinbalaji thenithinbalaji merged commit 6404a4e into thenithinbalaji:main Mar 13, 2022
Repository owner locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thenithinbalaji thenithinbalaji thenithinbalaji approved these changes

Assignees

@GokulramGHV GokulramGHV

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GokulramGHV @thenithinbalaji