-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix diversity #138
Fix diversity #138
Conversation
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 40.35% 50.07% +9.71%
==========================================
Files 8 9 +1
Lines 560 657 +97
==========================================
+ Hits 226 329 +103
+ Misses 334 328 -6
|
I am good with the current PR. We are missing one test for Do you have any suggestions and is there anything we are still missing for the PR? I will fix the conflicts once you think this is good to merge. @FarnazH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with most of the changes in this PR. Do you have any other comments? @FarnazH
The only problem is coding style, which I will address it later. |
Refactor diversity module
Address post pull request task list on Issue 130