Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diversity #138

Merged
merged 18 commits into from
Sep 16, 2023
Merged

Fix diversity #138

merged 18 commits into from
Sep 16, 2023

Conversation

AWBroscius
Copy link
Collaborator

Address post pull request task list on Issue 130

@FarnazH FarnazH self-requested a review June 20, 2023 20:44
DiverseSelector/diversity.py Outdated Show resolved Hide resolved
DiverseSelector/diversity.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #138 (5b9f1e8) into main (c17b346) will increase coverage by 9.71%.
Report is 13 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   40.35%   50.07%   +9.71%     
==========================================
  Files           8        9       +1     
  Lines         560      657      +97     
==========================================
+ Hits          226      329     +103     
+ Misses        334      328       -6     
Files Changed Coverage Δ
DiverseSelector/distance.py 100.00% <ø> (ø)
DiverseSelector/converter.py 100.00% <100.00%> (ø)
DiverseSelector/diversity.py 100.00% <100.00%> (+4.34%) ⬆️
DiverseSelector/methods/dissimilarity.py 18.60% <100.00%> (ø)
DiverseSelector/utils.py 100.00% <100.00%> (+12.50%) ⬆️

DiverseSelector/diversity.py Outdated Show resolved Hide resolved
DiverseSelector/diversity.py Outdated Show resolved Hide resolved
@FarnazH FarnazH self-requested a review July 6, 2023 11:51
@FanwangM
Copy link
Collaborator

I am good with the current PR.

We are missing one test for explicit_diversity_index. We can use RDKit to generate the small dataset in Figure 4A and use that as a test, https://pubs.acs.org/doi/10.1021/ci060074f. This may be a good exercise for someone who wants to learn more about RDKit.

Do you have any suggestions and is there anything we are still missing for the PR? I will fix the conflicts once you think this is good to merge. @FarnazH

Copy link
Collaborator

@FanwangM FanwangM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with most of the changes in this PR. Do you have any other comments? @FarnazH

DiverseSelector/diversity.py Outdated Show resolved Hide resolved
DiverseSelector/diversity.py Outdated Show resolved Hide resolved
@FanwangM
Copy link
Collaborator

The only problem is coding style, which I will address it later.

@FanwangM FanwangM merged commit 011b3b3 into main Sep 16, 2023
5 of 10 checks passed
JackyZzZz pushed a commit to JackyZzZz/Selector that referenced this pull request Jun 14, 2024
FanwangM added a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants