-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick Start Notebook #186
Quick Start Notebook #186
Conversation
The changes made to the notebook where: 1. Added function to render the result tables 2. Measured the diversity of the selected sets 3. Added selections based on n-similarity methods Additionally: 4. Added example using n-similarity methods to compute diversity
@FarnazH @maximilianvz I went through the notebook and:
Can you tell me what you think about it after a quick look?
Several things to note are:
|
@FarnazH and @marco-2023, I have several comments:
|
When computing diversity, a distance matrix is used. We should use the feature matrix instead I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing the updated notebooks. They look good to me. I did some cleaning up and keep working on these notebooks.
I will merge them first and then get a cleaner version soon.
This PR contains the
quick_start.ipynb
showcasing various functionalities of the package alongside a clear comparison of methods. While working on this notebook, I improved the package code/docstring and fixed some bugs. These changes are directly pushed to themain
branch so that we can move faster with our release. The method comparison figures (selecting from one cluster) have been added to the paper. There is still some work that needs to be done.@marco-2023, can you please:
TODO
items comparing the sections through diversity measures.@maximilianvz, can you please review this PR and share any comments you have on the notebook?