Skip to content

Commit

Permalink
added eslint await error (#393)
Browse files Browse the repository at this point in the history
* added eslint await error

* fix the linter issue
  • Loading branch information
ejahnGithub committed Jul 12, 2023
1 parent 5ade6e3 commit 00f7e7a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
12 changes: 7 additions & 5 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
{
"root": true,
"parser": "@typescript-eslint/parser",
"plugins": [
"@typescript-eslint",
"prettier"
],
"parserOptions": {
"project": "tsconfig.base.json",
"sourceType": "module"
},
"plugins": ["@typescript-eslint", "prettier"],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended",
"prettier"
],
"rules": {
"prettier/prettier": ["error"]
"prettier/prettier": ["error"],
"@typescript-eslint/require-await": "error"
}
}
4 changes: 2 additions & 2 deletions packages/client/src/__tests__/utils/tmpfile.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { withTempFile } from '../../utils/tmpfile';

describe('withTempFile', () => {
it('creates a temporary file', async () => {
const file = await withTempFile(async (tmpFileName) => {
const file = await withTempFile((tmpFileName) => {
expect(tmpFileName).toBeTruthy();
return tmpFileName;
return Promise.resolve(tmpFileName);
});

// Check to make sure the file has been deleted
Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/updater.ts
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ export class Updater {
return path.join(this.targetDir, filePath);
}

private async persistMetadata(metaDataName: string, bytesData: Buffer) {
private persistMetadata(metaDataName: string, bytesData: Buffer) {
try {
const filePath = path.join(this.dir, `${metaDataName}.json`);
log('WRITE %s', filePath);
Expand Down

0 comments on commit 00f7e7a

Please sign in to comment.