Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: device profile operation guide #3102

Merged
merged 2 commits into from
Sep 5, 2024
Merged

docs: device profile operation guide #3102

merged 2 commits into from
Sep 5, 2024

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Add device profile operation guide for users (with screenshots)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added documentation Improvements or additions to documentation theme:profile Device Profile labels Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
501 0 2 501 100 1h27m17.358482999s

albinsuresh
albinsuresh approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/src/operate/c8y/device-profiles.md Outdated Show resolved Hide resolved
docs/src/operate/c8y/device-profiles.md Outdated Show resolved Hide resolved
didier-wenzek
didier-wenzek approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller
add operation docs for device profiles
8526036 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller
rename device profiles reference page for consistency with c8y docs
0e1c7b6 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Sep 5, 2024
Merged via the queue into thin-edge:main with commit e13ab90 Sep 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligorisaev gligorisaev gligorisaev left review comments

@albinsuresh albinsuresh albinsuresh approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation theme:profile Device Profile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reubenmiller @albinsuresh @didier-wenzek @gligorisaev