Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initialize the remote access plugin in the container image #3120

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: initialize the remote access plugin in the container image #3120

merged 1 commit into from
Sep 10, 2024

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Initialize the c8y-remote-access-plugin within the docker container so that it is enabled by default.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
feat: initialize the remote access plugin in the container image
03dd13d 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added theme:packaging Theme: Packaging and release artefact topics theme:containers Theme: Containerisation topics labels Sep 10, 2024
@reubenmiller reubenmiller mentioned this pull request Sep 10, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
504 0 2 504 100 1h26m36.566689s

didier-wenzek
didier-wenzek approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Sep 10, 2024
Merged via the queue into thin-edge:main with commit e8b3405 Sep 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@rina23q rina23q rina23q approved these changes

Assignees
No one assigned
Labels
theme:containers Theme: Containerisation topics theme:packaging Theme: Packaging and release artefact topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reubenmiller @didier-wenzek @rina23q