Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: publish pid as number instead of string #3127

Merged
merged 1 commit into from
Sep 23, 2024
Merged

docs: publish pid as number instead of string #3127

merged 1 commit into from
Sep 23, 2024
+1 −1

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Fix documentation where the service status was still publishing as a string instead of a json number.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
docs: publish pid as number instead of string
977dfdb 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added the documentation Improvements or additions to documentation label Sep 22, 2024
@reubenmiller reubenmiller added the theme:monitoring Theme: Service monitoring and watchdogs label Sep 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
505 0 2 505 100 1h28m48.817079999s

didier-wenzek
didier-wenzek approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Sep 23, 2024
Merged via the queue into thin-edge:main with commit 67b951e Sep 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinsuresh albinsuresh albinsuresh approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@gligorisaev gligorisaev Awaiting requested review from gligorisaev gligorisaev is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation theme:monitoring Theme: Service monitoring and watchdogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reubenmiller @albinsuresh @didier-wenzek