Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change psylow_subgroup to sylow_subgroup #1355

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

StevellM
Copy link
Collaborator

@StevellM StevellM commented Jan 18, 2024

Related to renaming and consistency with the similar Oscar function: fixes #1015.

I have adapted the documentation to be as close as possible to the Oscar one, plus an example for free.

This would also require an Oscar counterpart where we remove the sylow_subgroup(::GrpAbFinGen) there (see https://github.com/oscar-system/Oscar.jl/blob/a7f9f88b91237001e8fcc467ff0e24892d641d41/src/Groups/GrpAb.jl#L285C1-L300C4)

@thofma
Copy link
Owner

thofma commented Jan 18, 2024

Thanks!

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #1355 (5c584db) into master (bf8c367) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
- Coverage   70.29%   70.25%   -0.05%     
==========================================
  Files         351      351              
  Lines      111785   111785              
==========================================
- Hits        78578    78531      -47     
- Misses      33207    33254      +47     
Files Coverage Δ
src/Deprecations.jl 100.00% <ø> (ø)
src/Grp/GenGrp.jl 69.38% <100.00%> (ø)
src/GrpAb/GrpAbFinGen.jl 77.98% <100.00%> (ø)
src/GrpAb/SubgroupEnum.jl 83.87% <100.00%> (ø)
src/GrpAb/stable_sub.jl 82.04% <100.00%> (ø)
ext/GAPExt/maximal_abelian_subextension.jl 0.00% <0.00%> (ø)

... and 26 files with indirect coverage changes

@fingolfin
Copy link
Contributor

@StevellM can you edit the description of this PR to include something like "fixes #1015" or "resolves #1015" so that merging this PR will close that issue?

@thofma thofma merged commit ea33652 into thofma:master Jan 26, 2024
18 checks passed
@lgoettgens
Copy link
Contributor

This would also require an Oscar counterpart where we remove the sylow_subgroup(::GrpAbFinGen) there (see oscar-system/Oscar.jl@a7f9f88/src/Groups/GrpAb.jl#L285C1-L300C4)

I just added this change to oscar-system/Oscar.jl#3231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the name sylow_subgroup in Hecke
4 participants