feat: default visibility #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolheiser
force-pushed
the
default-visibility
branch
from
053f39b
to
6ce8c20
Compare
|
Thanks for the PR :) Please see my comment in #152 where I find it better to have visibilities tied to client side, what do you think about it ? Although I really like the changes about the Visibility type in the code, if you're willing to cherry pick only those changes then i'm fine with it for now |
|
I like that idea as well, would be more than happy to change the implementation. 🤝 |
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser
force-pushed
the
default-visibility
branch
from
6ce8c20
to
3859527
Compare
|
This should address it on the web UI. The terminal will take a bit more thought, as the URL doesn't work well with query params due to how git sends packs/etc. based on the URL An alternative solution is to use push options, for example git push -o visibility=unlistedand then handling that on the server end. |
thomiceli
pushed a commit
that referenced
this pull request
Jan 4, 2024
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jiriks74
pushed a commit
to jiriks74/opengist
that referenced
this pull request
Apr 28, 2024
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #152
Feel free to use or discard any parts of this PR, it was a worthwhile exercise for me to look at the code more closely either way. 🙂
The formatting is a result of my setup using
goimportsandgofumpt, I am willing to cherry-pick out the changes without the formatting noise if you prefer it that way as well.