Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify custom names in the OAuth login buttons #214

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

crapStone
Copy link
Contributor

@crapStone crapStone commented Jan 24, 2024

closes #154

Explanation why I chose that path is also in that issue.

@alyssadev
Copy link

I would also suggest this change I've made on my own instance 7e5d427

@thomiceli
Copy link
Owner

Throwing a random idea : use the domain name of the instance to get the name instead of a new config

@alyssadev
Copy link

Perhaps this could be fetched automatically with the option to override. Any html page on a Gitea-compatible instance should have a meta property tag for og:site_name, i imagine we'd want to parse out the "Git with a cup of tea" thing that seems to be present unless explicitly removed, as in the Gitea instance I have my opengist instance connected to.

<meta property="og:site_name" content="TWS Gitea: Git with a cup of tea">

@crapStone
Copy link
Contributor Author

I would also suggest this change I've made on my own instance 7e5d427

I talked with a friend about that page, but it dind't cross my mind to add the new config fields there 😆

@crapStone
Copy link
Contributor Author

Throwing a random idea : use the domain name of the instance to get the name instead of a new config

I'm evaluating this service for Codeberg (see here) and just using codeberg.org isn't enough, because we are not just another Forgejo/Gitea instance.

I could add a check after the parsing of the config and if no custom name is set the name will be set to the domain name.

@jolheiser
Copy link
Contributor

fwiw I think this impl is fine. A domain check seems like it may be overcomplicating it when an override exists.

@thomiceli thomiceli changed the base branch from master to dev-1.7 February 19, 2024 01:15
@thomiceli
Copy link
Owner

Thank you for the contributions :)

@thomiceli thomiceli merged commit 0b01200 into thomiceli:dev-1.7 Feb 19, 2024
5 checks passed
jiriks74 pushed a commit to jiriks74/opengist that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Gitea/Forgejo
4 participants