-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify custom names in the OAuth login buttons #214
Add ability to specify custom names in the OAuth login buttons #214
Conversation
I would also suggest this change I've made on my own instance 7e5d427 |
Throwing a random idea : use the domain name of the instance to get the name instead of a new config |
Perhaps this could be fetched automatically with the option to override. Any html page on a Gitea-compatible instance should have a meta property tag for <meta property="og:site_name" content="TWS Gitea: Git with a cup of tea"> |
I talked with a friend about that page, but it dind't cross my mind to add the new config fields there 😆 |
I'm evaluating this service for Codeberg (see here) and just using I could add a check after the parsing of the config and if no custom name is set the name will be set to the domain name. |
fwiw I think this impl is fine. A domain check seems like it may be overcomplicating it when an override exists. |
Thank you for the contributions :) |
closes #154
Explanation why I chose that path is also in that issue.