Refactor BrewFlasher.com Integration #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
brewflasher_com_integration.pyto match the one in use by BrewFlasher CLI edition in order to keep the two in sync. This changes the object definitions to use@dataclasssyntax for better type hinting and adds theDeviceFamilyobject to theFirmwareobject to simplify some of the logic.This PR also refactors out the "flash" action into its own function -
flash_firmware_using_whatever_is_appropriate()- which (mostly) matches the one in use within BrewFlasher CLI. This should (hopefully!) allow the two to remain in sync, and also adds BrewFlasher CLI's Arduino support to BrewFlasher Desktop.