Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call PyEval_InitThreads() on Python 3.7+ #132

Merged
merged 3 commits into from
May 31, 2024
Merged

Don't call PyEval_InitThreads() on Python 3.7+ #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d45bf29
Remove PyEval_InitThreads() call
vstinner Apr 16, 2024
a7b0a6d
Update changelog
vstinner May 23, 2024
3e1e18c
Versions are only assigned on release
thp May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ The image provider must return a tuple ``(data, size, format)``:
The pixel format of ``data`` (see `constants`_),
``pyotherside.format_data`` if ``data`` contains an
encoded (PNG/JPEG) image instead of raw pixel data
or ``pyotherside.format_svg_data`` if ``data`` contains
or ``pyotherside.format_svg_data`` if ``data`` contains
SVG image XML data.

In order to register the image provider with PyOtherSide for use
Expand Down Expand Up @@ -1196,6 +1196,12 @@ flags for compiling and linking against Python on your system.
ChangeLog
=========

Version UNRELEASED
------------------

* No longer call PyEval_InitThreads() at Python startup. It's no longer needed
since Python 3.7.

Version 1.6.1 (2024-05-18)
--------------------------

Expand Down
1 change: 0 additions & 1 deletion src/qpython_priv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,6 @@ QPythonPriv::QPythonPriv()
PyImport_AppendInittab("pyotherside", PyOtherSide_init);

Py_InitializeEx(0);
PyEval_InitThreads();

// Initialize sys.argv (https://github.com/thp/pyotherside/issues/77)
int argc = 1;
Expand Down
Loading