Update TiDB Dashboard to v2021.09.02.r40.1 [release-5.0] (#4417)

* Update TiDB Dashboard to v2021.09.02.r40.1, ref #4257 Signed-off-by: tidb-dashboard-bot <tidb-dashboard-bot@pingcap.com> * fix statics Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: tidb-dashboard-bot <tidb-dashboard-bot@pingcap.com> Co-authored-by: ShuNing <nolouch@gmail.com>
tikv · Dec 20, 2021 · 073e629 · 073e629
1 parent 634194f
commit 073e629
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/go.mod b/go.mod
@@ -31,7 +31,7 @@ require (
 	github.com/pingcap/kvproto v0.0.0-20210219064844-c1844a4775d6
 	github.com/pingcap/log v0.0.0-20210317133921-96f4fcab92a4
 	github.com/pingcap/sysutil v0.0.0-20210315073920-cc0985d983a3
-	github.com/pingcap/tidb-dashboard v0.0.0-20210902124511-e723204205f7
+	github.com/pingcap/tidb-dashboard v0.0.0-20211202025153-5cbd8ed00fd3
 	github.com/prometheus/client_golang v1.2.1
 	github.com/prometheus/common v0.9.1
 	github.com/sasha-s/go-deadlock v0.2.0

diff --git a/go.sum b/go.sum
@@ -331,8 +331,8 @@ github.com/pingcap/log v0.0.0-20210317133921-96f4fcab92a4 h1:ERrF0fTuIOnwfGbt71J
 github.com/pingcap/log v0.0.0-20210317133921-96f4fcab92a4/go.mod h1:4rbK1p9ILyIfb6hU7OG2CiWSqMXnp3JMbiaVJ6mvoY8=
 github.com/pingcap/sysutil v0.0.0-20210315073920-cc0985d983a3 h1:A9KL9R+lWSVPH8IqUuH1QSTRJ5FGoY1bT2IcfPKsWD8=
 github.com/pingcap/sysutil v0.0.0-20210315073920-cc0985d983a3/go.mod h1:tckvA041UWP+NqYzrJ3fMgC/Hw9wnmQ/tUkp/JaHly8=
-github.com/pingcap/tidb-dashboard v0.0.0-20210902124511-e723204205f7 h1:uYimp8O2UlwlZm/gMlPDXvuCCTKQETRc8iFmPpxNi78=
-github.com/pingcap/tidb-dashboard v0.0.0-20210902124511-e723204205f7/go.mod h1:OCXbZTBTIMRcIt0jFsuCakZP+goYRv6IjawKbwLS2TQ=
+github.com/pingcap/tidb-dashboard v0.0.0-20211202025153-5cbd8ed00fd3 h1:dh5aFH9egW1IbK+2YN0GoFKbO/Fy6qa1kbf67+N+Vbk=
+github.com/pingcap/tidb-dashboard v0.0.0-20211202025153-5cbd8ed00fd3/go.mod h1:OCXbZTBTIMRcIt0jFsuCakZP+goYRv6IjawKbwLS2TQ=
 github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=

diff --git a/pkg/errs/errs_test.go b/pkg/errs/errs_test.go
@@ -15,7 +15,6 @@ package errs
 
 import (
 	"bytes"
-	"fmt"
 	"strconv"
 	"strings"
 	"testing"
@@ -38,7 +37,7 @@ func newTestingWriter() *testingWriter {
 func (w *testingWriter) Write(p []byte) (n int, err error) {
 	n = len(p)
 	p = bytes.TrimRight(p, "\n")
-	m := fmt.Sprintf("%s", p)
+	m := string(p)
 	w.messages = append(w.messages, m)
 	return n, nil
 }

diff --git a/server/statistics/topn.go b/server/statistics/topn.go
@@ -289,7 +289,7 @@ func (hp *indexedHeap) Get(id uint64) TopNItem {
 		return nil
 	}
 	item := hp.items[idx]
-	return item.(TopNItem)
+	return item
 }
 
 // GetAll returns all the items.