Update estimated latency metric in tsoStream instead of tsoDispatcher

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
tikv · Sep 25, 2024 · af1c3d2 · af1c3d2
1 parent 0bfe9a6
commit af1c3d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/client/tso_dispatcher.go b/client/tso_dispatcher.go
@@ -353,7 +353,6 @@ tsoBatchLoop:
 		// continue collecting.
 		if td.isConcurrentRPCEnabled() {
 			estimatedLatency := stream.EstimatedRPCLatency()
-			estimateTSOLatencyGauge.WithLabelValues(streamURL).Set(estimatedLatency.Seconds())
 			goalBatchTime := estimatedLatency / time.Duration(td.rpcConcurrency)
 
 			failpoint.Inject("tsoDispatcherConcurrentModeAssertDelayDuration", func(val failpoint.Value) {

diff --git a/client/tso_stream.go b/client/tso_stream.go
@@ -386,6 +386,8 @@ func (s *tsoStream) recvLoop(ctx context.Context) {
 		currentSample := math.Log(float64(latency.Microseconds()))
 		filteredValue := filter.update(sampleTime, currentSample)
 		s.estimatedLatencyMicros.Store(uint64(math.Exp(filteredValue)))
+		// `filteredValue` is in microseconds. Update the metrics in seconds.
+		estimateTSOLatencyGauge.WithLabelValues(s.streamID).Set(filteredValue * 1e-6)
 	}
 
 recvLoop: