Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer is accidently removed when scatter region #4565

Closed
rleungx opened this issue Jan 12, 2022 · 1 comment · Fixed by #4570
Closed

Peer is accidently removed when scatter region #4565

rleungx opened this issue Jan 12, 2022 · 1 comment · Fixed by #4570
Assignees
@HunDunDM
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 severity/major type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jan 12, 2022

Bug Report

Screen Shot 2022-01-12 at 4 28 21 PM

What did you do?

Use API to scatter regions.

What did you expect to see?

There should be only scatter-region operators.

What did you see instead?

Screen Shot 2022-01-12 at 4 31 55 PM

What version of PD are you using (pd-server -V)?

master and v5.4.0
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Jan 12, 2022
@mayjiang0203
Copy link

/severity major

HunDunDM added a commit to HunDunDM/pd that referenced this issue Jan 13, 2022
@HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
2f8acee 
…ew peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM mentioned this issue Jan 13, 2022
Merged
HunDunDM added a commit to HunDunDM/pd that referenced this issue Jan 14, 2022
@HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
3e8683a 
…ew peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot pushed a commit that referenced this issue Jan 14, 2022
@HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
c31556a 
…ew peers (#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close #4565

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix import

Signed-off-by: HunDunDM <hundundm@gmail.com>

* better select strategy

Signed-off-by: HunDunDM <hundundm@gmail.com>

* tiny fix

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM @ti-chi-bot
region_scatterer: fix the bug that could generate schedule with too f…
8b79198 
…ew peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jan 14, 2022
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM @ti-chi-bot
region_scatterer: fix the bug that could generate schedule with too f…
401395c 
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix import

Signed-off-by: HunDunDM <hundundm@gmail.com>

* better select strategy

Signed-off-by: HunDunDM <hundundm@gmail.com>

* tiny fix

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jan 14, 2022
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM @ti-chi-bot
region_scatterer: fix the bug that could generate schedule with too f…
f9ccafc 
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix import

Signed-off-by: HunDunDM <hundundm@gmail.com>

* better select strategy

Signed-off-by: HunDunDM <hundundm@gmail.com>

* tiny fix

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM @ti-chi-bot
region_scatterer: fix the bug that could generate schedule with too f…
f229e75 
…ew peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>
This was referenced Jan 14, 2022
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM @ti-chi-bot
region_scatterer: fix the bug that could generate schedule with too f…
3274752 
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix import

Signed-off-by: HunDunDM <hundundm@gmail.com>

* better select strategy

Signed-off-by: HunDunDM <hundundm@gmail.com>

* tiny fix

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jan 14, 2022
Merged
HunDunDM added a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
87ffadc 
…ew peers (tikv#4570)

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>
HunDunDM added a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
618f1cf 
…ew peers (tikv#4570)

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>
HunDunDM added a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
@HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
941b69d 
…ew peers (tikv#4570)

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>
@rleungx rleungx mentioned this issue Jan 14, 2022
Open
ti-chi-bot added a commit that referenced this issue Jan 21, 2022
@ti-chi-bot @HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
f4ed192 
…ew peers (#4570) (#4579)

* region_scatterer: fix the bug that could generate schedule with too few peers (#4570)

close #4565

Signed-off-by: HunDunDM <hundundm@gmail.com>

* region_scatterer: fix incorrect test (#4586)

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
disksing pushed a commit to oh-my-tidb/pd that referenced this issue Feb 8, 2022
@HunDunDM @disksing
region_scatterer: fix the bug that could generate schedule with too f…
c3c41bd 
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix import

Signed-off-by: HunDunDM <hundundm@gmail.com>

* better select strategy

Signed-off-by: HunDunDM <hundundm@gmail.com>

* tiny fix

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this issue Feb 22, 2022
@ti-chi-bot @HunDunDM @JmPotato
region_scatterer: fix the bug that could generate schedule with too f…
76025f6 
…ew peers (#4570) (#4577)

close #4565, ref #4570

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot added a commit that referenced this issue Apr 14, 2022
@ti-chi-bot @HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
5a77718 
…ew peers (#4570) (#4580)

close #4565, ref #4570

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: 混沌DM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this issue Jun 13, 2022
@ti-chi-bot @HunDunDM
region_scatterer: fix the bug that could generate schedule with too f…
498d5db 
…ew peers (#4570) (#4578)

close #4565, ref #4570

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HunDunDM HunDunDM

Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

region_scatterer: fix the bug that could generate schedule with too few peers HunDunDM/pd
5 participants
@jebter @mayjiang0203 @HunDunDM @rleungx @ti-chi-bot