Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schedulers]: get stores only once #4003

Merged
merged 10 commits into from
Aug 19, 2021

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Aug 18, 2021

Signed-off-by: bufferflies 1045931706@qq.com

What problem does this PR solve?

related #3744, Get stores only once to reduce scheduler execute time
image

What is changed and how it works?

stores should get once before schedule and it should input to plan

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

balance leader and balance region scheduler should calculator get Stores only once  to improve balance  performance

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2021
server/core/store.go Outdated Show resolved Hide resolved
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #4003 (eab1ff5) into master (ccc8bcd) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4003      +/-   ##
==========================================
- Coverage   74.61%   74.49%   -0.12%     
==========================================
  Files         254      255       +1     
  Lines       25826    25831       +5     
==========================================
- Hits        19269    19243      -26     
- Misses       4847     4867      +20     
- Partials     1710     1721      +11     
Flag Coverage Δ
unittests 74.49% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/coordinator.go 73.64% <100.00%> (+0.05%) ⬆️
server/schedule/opt/opts.go 100.00% <100.00%> (ø)
server/tso/tso.go 62.43% <0.00%> (-5.53%) ⬇️
server/region_syncer/client.go 77.46% <0.00%> (-4.23%) ⬇️
server/statistics/hot_cache_task.go 75.00% <0.00%> (-4.17%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/server.go 70.51% <0.00%> (-1.52%) ⬇️
server/member/member.go 65.24% <0.00%> (-1.07%) ⬇️
server/cluster/cluster.go 82.22% <0.00%> (-0.83%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc8bcd...eab1ff5. Read the comment docs.

Signed-off-by: bufferflies <1045931706@qq.com>
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

server/schedule/opt/opts.go Outdated Show resolved Hide resolved
server/schedule/opt/opts.go Outdated Show resolved Hide resolved
@HunDunDM
Copy link
Member

Please fix the test

Signed-off-by: bufferflies <1045931706@qq.com>
HunDunDM added a commit to HunDunDM/pd that referenced this pull request Aug 19, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Aug 19, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eab1ff5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2021
@ti-chi-bot ti-chi-bot merged commit 550cf1c into tikv:master Aug 19, 2021
@bufferflies bufferflies deleted the feature/getStoresOnce branch February 17, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants