Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* : testify all pkg tests #5091

Merged
merged 3 commits into from
Jun 2, 2022
Merged

* : testify all pkg tests #5091

merged 3 commits into from
Jun 2, 2022

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jun 2, 2022

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Issue Number: ref #4813.

What is changed and how does it work?

Testify all pkg tests.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added the component/testing CI testing. label Jun 2, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2022
@JmPotato JmPotato mentioned this pull request Jun 2, 2022
85 tasks
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #5091 (01cdd9e) into master (d7435da) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 01cdd9e differs from pull request most recent head 203850a. Consider uploading reports for the commit 203850a to get more accurate results

@@            Coverage Diff             @@
##           master    #5091      +/-   ##
==========================================
- Coverage   75.45%   75.43%   -0.03%     
==========================================
  Files         308      308              
  Lines       30475    30475              
==========================================
- Hits        22995    22988       -7     
- Misses       5480     5488       +8     
+ Partials     2000     1999       -1     
Flag Coverage Δ
unittests 75.43% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/storage.go 64.86% <0.00%> (-5.41%) ⬇️
server/member/member.go 63.68% <0.00%> (-3.69%) ⬇️
server/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
server/storage/endpoint/meta.go 61.79% <0.00%> (-2.25%) ⬇️
client/base_client.go 79.38% <0.00%> (-2.07%) ⬇️
server/tso/allocator_manager.go 63.39% <0.00%> (-1.50%) ⬇️
server/config/persist_options.go 93.09% <0.00%> (-0.73%) ⬇️
server/tso/tso.go 71.75% <0.00%> (-0.57%) ⬇️
server/grpc_service.go 52.60% <0.00%> (-0.18%) ⬇️
server/server.go 73.23% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7435da...203850a. Read the comment docs.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2022
@JmPotato
Copy link
Member Author

JmPotato commented Jun 2, 2022

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 01cdd9e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2022
@ti-chi-bot
Copy link
Member

@JmPotato: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fc55b44 into tikv:master Jun 2, 2022
@JmPotato JmPotato deleted the testify_pkg branch June 2, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants