Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: disable swagger server (#4934) #5177

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4934

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Issue Number: Close #4932

before:
make pd-server  213.93s user 43.70s system 279% cpu 1:32.05 total
after:
make pd-server  209.82s user 37.90s system 286% cpu 1:26.54 to

imporve about 5/43.7 = 11%

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

server: disable swagger server

close tikv#4932

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. labels Jun 17, 2022
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #5177 (9281ef6) into release-5.3 (81cd0ce) will increase coverage by 0.21%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release-5.3    #5177      +/-   ##
===============================================
+ Coverage        74.88%   75.10%   +0.21%     
===============================================
  Files              263      263              
  Lines            27359    27359              
===============================================
+ Hits             20489    20547      +58     
+ Misses            5054     5006      -48     
+ Partials          1816     1806      -10     
Flag Coverage Δ
unittests 75.10% <0.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/swaggerserver/empty_handler.go 0.00% <0.00%> (ø)
server/schedule/operator/step.go 71.09% <0.00%> (-0.79%) ⬇️
server/core/storage.go 68.79% <0.00%> (-0.76%) ⬇️
server/server.go 71.82% <0.00%> (-0.45%) ⬇️
server/cluster/cluster.go 82.21% <0.00%> (-0.24%) ⬇️
pkg/tempurl/tempurl.go 60.00% <0.00%> (ø)
server/schedule/operator_controller.go 84.25% <0.00%> (+0.40%) ⬆️
server/grpc_service.go 51.11% <0.00%> (+0.50%) ⬆️
server/election/leadership.go 77.31% <0.00%> (+2.06%) ⬆️
pkg/dashboard/adapter/manager.go 85.10% <0.00%> (+2.12%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81cd0ce...9281ef6. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 20, 2022
@@ -24,6 +24,6 @@ import (

func handler() http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
_, _ = io.WriteString(w, "Swagger UI is not built. Try `make` without `SWAGGER=0`.\n")
_, _ = io.WriteString(w, "Swagger UI is not built. Try `make` without `SWAGGER=1`.\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it doesn't need to change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default behavior changed.

@nolouch
Copy link
Contributor

nolouch commented Jun 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9281ef6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@ti-chi-bot ti-chi-bot merged commit eea08fb into tikv:release-5.3 Jun 20, 2022
@purelind purelind added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants