ci: support real cluster test in jenkins #7493

HuSharp · 2023-12-05T02:41:23Z

What problem does this PR solve?

Issue Number: Ref #7298

wait #7516 merged

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Release note

None.

ti-chi-bot · 2023-12-05T02:41:26Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-12-05T02:41:26Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2023-12-05T02:56:22Z

Codecov Report

Merging #7493 (e296e7e) into master (f51f913) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7493      +/-   ##
==========================================
+ Coverage   74.65%   74.66%   +0.01%     
==========================================
  Files         454      454              
  Lines       50142    50142              
==========================================
+ Hits        37432    37440       +8     
+ Misses       9385     9373      -12     
- Partials     3325     3329       +4

Flag	Coverage Δ
unittests	`74.66% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

tests/integrations/realtiup/download_binaries.sh

Signed-off-by: husharp <jinhao.hu@pingcap.com>

rely on tikv/pd#7493 --------- Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: Purelind <purelind@users.noreply.github.com>

purelind · 2023-12-08T02:19:44Z

/test ?

ti-chi-bot · 2023-12-08T02:19:47Z

@purelind: The following commands are available to trigger required jobs:

/test build

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test
/test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

purelind · 2023-12-08T02:19:58Z

/test pull-integration-realcluster-test

HuSharp · 2023-12-14T01:56:51Z

can be checked on https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Fpd%2Fpull_integration_realcluster_test/activity

HuSharp · 2023-12-14T07:11:29Z

/test pull-integration-realcluster-test

HuSharp · 2023-12-14T07:24:00Z

Makefile

+RELEASE_VERSION ?= $(shell git describe --tags --dirty --always)
+ifeq ($(RUN_CI), 1)
+	RELEASE_VERSION := None
+endif
+
+LDFLAGS += -X "$(PD_PKG)/pkg/versioninfo.PDReleaseVersion=$(RELEASE_VERSION)"


there is no tag in the ci environment, we can not pass

pd/server/util.go

Lines 39 to 41 in bfc988b

if versioninfo.PDReleaseVersion != "None" {

pdVersion = versioninfo.MustParseVersion(versioninfo.PDReleaseVersion)

}

whithout tag :(

bufferflies · 2023-12-14T07:36:20Z

/test ?

ti-chi-bot · 2023-12-14T07:36:22Z

@bufferflies: The following commands are available to trigger required jobs:

/test build

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test
/test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tests/integrations/realtiup/mock_db.go

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-12-14T08:23:50Z

/test pull-integration-realcluster-test

tests/integrations/realtiup/deploy.sh

bufferflies · 2023-12-18T01:55:57Z

/merge

ti-chi-bot · 2023-12-18T01:55:59Z

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-12-18T01:56:01Z

This pull request has been accepted and is ready to merge.

Commit hash: e296e7e

bufferflies · 2023-12-18T02:15:55Z

/rebuild

bufferflies · 2023-12-18T02:16:11Z

/retest

bufferflies · 2023-12-18T02:16:34Z

/rerun

bufferflies · 2023-12-18T02:16:50Z

/test

ti-chi-bot · 2023-12-18T02:16:52Z

@bufferflies: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test
/test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bufferflies · 2023-12-18T02:17:05Z

/test all

ti-chi-bot bot added the do-not-merge/needs-linked-issue label Dec 5, 2023

ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 5, 2023

ti-chi-bot bot requested review from nolouch and Yisaer December 5, 2023 02:41

ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 5, 2023

HuSharp force-pushed the support_jenkins branch from f29a9b8 to 788b32a Compare December 5, 2023 02:42

HuSharp removed request for nolouch and Yisaer December 5, 2023 02:42

HuSharp force-pushed the support_jenkins branch from 788b32a to fa0d5b6 Compare December 5, 2023 03:53

This was referenced Dec 5, 2023

pd: support pd real cluster PingCAP-QE/ci#2655

Merged

tests: add integration test and ci workflow for real tiup #7317

Closed

purelind reviewed Dec 5, 2023

View reviewed changes

tests/integrations/realtiup/download_binaries.sh Outdated Show resolved Hide resolved

HuSharp force-pushed the support_jenkins branch 2 times, most recently from fed4447 to c2f7fbf Compare December 7, 2023 08:15

use bin

a8985fb

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the support_jenkins branch from c2f7fbf to a8985fb Compare December 7, 2023 08:38

fix test

cc50140

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp marked this pull request as ready for review December 7, 2023 09:28

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2023

HuSharp changed the title ~~[DNM] ci: support test in jenkins~~ ci: support real cluster test in jenkins Dec 7, 2023

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Dec 7, 2023

Merge branch 'master' into support_jenkins

e240aa6

HuSharp requested review from lhy1024, CabinfeverB and rleungx December 14, 2023 01:55

Merge branch 'master' into support_jenkins

c5555f2

HuSharp commented Dec 14, 2023

View reviewed changes

rleungx approved these changes Dec 14, 2023

View reviewed changes

tests/integrations/realtiup/mock_db.go Outdated Show resolved Hide resolved

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2023

fmt

823c696

Signed-off-by: husharp <jinhao.hu@pingcap.com>

bufferflies reviewed Dec 14, 2023

View reviewed changes

tests/integrations/realtiup/deploy.sh Show resolved Hide resolved

Merge branch 'master' into support_jenkins

e318d28

bufferflies approved these changes Dec 14, 2023

View reviewed changes

Merge branch 'master' into support_jenkins

e296e7e

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2023

ti-chi-bot bot merged commit a4ab7d3 into tikv:master Dec 18, 2023
23 checks passed

HuSharp deleted the support_jenkins branch December 18, 2023 06:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: support real cluster test in jenkins #7493

ci: support real cluster test in jenkins #7493

HuSharp commented Dec 5, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 5, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 5, 2023

codecov bot commented Dec 5, 2023 •

edited

Loading

purelind commented Dec 8, 2023

ti-chi-bot bot commented Dec 8, 2023

purelind commented Dec 8, 2023

HuSharp commented Dec 14, 2023

HuSharp commented Dec 14, 2023

HuSharp Dec 14, 2023

bufferflies commented Dec 14, 2023

ti-chi-bot bot commented Dec 14, 2023

HuSharp commented Dec 14, 2023

bufferflies commented Dec 18, 2023

ti-chi-bot bot commented Dec 18, 2023

ti-chi-bot bot commented Dec 18, 2023

bufferflies commented Dec 18, 2023

bufferflies commented Dec 18, 2023

bufferflies commented Dec 18, 2023

bufferflies commented Dec 18, 2023

ti-chi-bot bot commented Dec 18, 2023

bufferflies commented Dec 18, 2023

	if versioninfo.PDReleaseVersion != "None" {
	pdVersion = versioninfo.MustParseVersion(versioninfo.PDReleaseVersion)
	}

ci: support real cluster test in jenkins #7493

ci: support real cluster test in jenkins #7493

Conversation

HuSharp commented Dec 5, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Dec 5, 2023 • edited Loading

ti-chi-bot bot commented Dec 5, 2023

codecov bot commented Dec 5, 2023 • edited Loading

Codecov Report

purelind commented Dec 8, 2023

ti-chi-bot bot commented Dec 8, 2023

purelind commented Dec 8, 2023

HuSharp commented Dec 14, 2023

HuSharp commented Dec 14, 2023

HuSharp Dec 14, 2023

Choose a reason for hiding this comment

bufferflies commented Dec 14, 2023

ti-chi-bot bot commented Dec 14, 2023

HuSharp commented Dec 14, 2023

bufferflies commented Dec 18, 2023

ti-chi-bot bot commented Dec 18, 2023

ti-chi-bot bot commented Dec 18, 2023

bufferflies commented Dec 18, 2023

bufferflies commented Dec 18, 2023

bufferflies commented Dec 18, 2023

bufferflies commented Dec 18, 2023

ti-chi-bot bot commented Dec 18, 2023

bufferflies commented Dec 18, 2023

HuSharp commented Dec 5, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 5, 2023 •

edited

Loading

codecov bot commented Dec 5, 2023 •

edited

Loading