Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: improve flow update #7791

Merged
merged 6 commits into from
Feb 4, 2024
Merged

tools: improve flow update #7791

merged 6 commits into from
Feb 4, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 1, 2024

What problem does this PR solve?

Issue Number: Ref #7703.

What is changed and how does it work?

Check List

Tests

  • Manual test

After this PR:

Screenshot 2024-02-02 at 17 39 31

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 1, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch February 1, 2024 10:04
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 1, 2024
@rleungx rleungx removed the request for review from nolouch February 1, 2024 10:29
Signed-off-by: Ryan Leung <rleungx@gmail.com>
bytesUnit = 8 * units.MiB
keysUint = 8 * units.KiB
queryUnit = 1 * units.KiB
bytesUnit = 128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we use it, we need to note that item of tikv heartbeat is the cumulative, which is used for hotspot determination is the rate.

For example, if the hotKeysUint is 256, the calculated rate is 25.6 for reads and 4.2 for writes, which is lower than the threshold for the hot side, so it won't be treated as a hot region.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #7791 (91b6383) into master (21ced9a) will decrease coverage by 0.10%.
Report is 1 commits behind head on master.
The diff coverage is 69.56%.

❗ Current head 91b6383 differs from pull request most recent head 2dd5abd. Consider uploading reports for the commit 2dd5abd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7791      +/-   ##
==========================================
- Coverage   73.55%   73.46%   -0.10%     
==========================================
  Files         432      432              
  Lines       47793    47836      +43     
==========================================
- Hits        35153    35141      -12     
- Misses       9612     9656      +44     
- Partials     3028     3039      +11     
Flag Coverage Δ
unittests 73.46% <69.56%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx marked this pull request as ready for review February 2, 2024 09:41
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2024
@CabinfeverB CabinfeverB self-requested a review February 2, 2024 09:45
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests for API?

server/api/operator.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Feb 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

@rleungx: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 4, 2024
@rleungx rleungx added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2024
@rleungx
Copy link
Member Author

rleungx commented Feb 4, 2024

/merge cancel

@rleungx
Copy link
Member Author

rleungx commented Feb 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 2dd5abd

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4975890 into tikv:master Feb 4, 2024
22 checks passed
@rleungx rleungx deleted the hot branch February 4, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants