*: use context to manage runner

[rleungx]

What problem does this PR solve?

Issue Number: ref #8386

What is changed and how does it work?

Check List

Tests

• Unit test

Release note

None.

[okJiang]

/test pull-integration-realcluster-test

[ti-chi-bot]

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.15%. Comparing base (ca179e6) to head (d55b270).
Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8394      +/-   ##
==========================================
- Coverage   77.24%   77.15%   -0.10%     
==========================================
  Files         471      471              
  Lines       61696    61700       +4     
==========================================
- Hits        47660    47607      -53     
- Misses      10454    10507      +53     
- Partials     3582     3586       +4     

Flag	Coverage Δ
unittests	77.15% <88.88%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[okJiang]

I found lots of repeated operator logs in the test. Is this because of the content of this pr? 🤔
https://do.pingcap.net/jenkins/blue/rest/organizations/jenkins/pipelines/tikv/pipelines/pd/pipelines/pull_integration_realcluster_test/runs/312/nodes/72/steps/77/log/?start=0

[2024/07/15 17:05:31.010 +08:00] [INFO] [operator_controller.go:510] ["add operator"] [region-id=52] [operator="\"grant-leader {transfer leader: store 2 to 3} (kind:leader, region:52(23, 5), createAt:2024-07-15 17:05:31.01069943 +0800 CST m=+78.032028045, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, size:0, steps:[0:{transfer leader from store 2 to store 3}], timeout:[1m0s])\""] [additional-info=]
...
[2024/07/15 17:05:34.512 +08:00] [INFO] [operator_controller.go:510] ["add operator"] [region-id=52] [operator="\"grant-leader {transfer leader: store 2 to 3} (kind:leader, region:52(23, 5), createAt:2024-07-15 17:05:34.512594216 +0800 CST m=+81.533922837, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, size:0, steps:[0:{transfer leader from store 2 to store 3}], timeout:[1m0s])\""] [additional-info=]
...
[2024/07/15 17:05:44.517 +08:00] [INFO] [operator_controller.go:510] ["add operator"] [region-id=52] [operator="\"grant-leader {transfer leader: store 2 to 3} (kind:leader, region:52(23, 5), createAt:2024-07-15 17:05:44.517445078 +0800 CST m=+91.538773699, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, size:0, steps:[0:{transfer leader from store 2 to store 3}], timeout:[1m0s])\""] [additional-info=]

[rleungx]

I found lots of repeated operator logs in the test. Is this because of the content of this pr? 🤔 https://do.pingcap.net/jenkins/blue/rest/organizations/jenkins/pipelines/tikv/pipelines/pd/pipelines/pull_integration_realcluster_test/runs/312/nodes/72/steps/77/log/?start=0

[2024/07/15 17:05:31.010 +08:00] [INFO] [operator_controller.go:510] ["add operator"] [region-id=52] [operator="\"grant-leader {transfer leader: store 2 to 3} (kind:leader, region:52(23, 5), createAt:2024-07-15 17:05:31.01069943 +0800 CST m=+78.032028045, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, size:0, steps:[0:{transfer leader from store 2 to store 3}], timeout:[1m0s])\""] [additional-info=]
...
[2024/07/15 17:05:34.512 +08:00] [INFO] [operator_controller.go:510] ["add operator"] [region-id=52] [operator="\"grant-leader {transfer leader: store 2 to 3} (kind:leader, region:52(23, 5), createAt:2024-07-15 17:05:34.512594216 +0800 CST m=+81.533922837, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, size:0, steps:[0:{transfer leader from store 2 to store 3}], timeout:[1m0s])\""] [additional-info=]
...
[2024/07/15 17:05:44.517 +08:00] [INFO] [operator_controller.go:510] ["add operator"] [region-id=52] [operator="\"grant-leader {transfer leader: store 2 to 3} (kind:leader, region:52(23, 5), createAt:2024-07-15 17:05:44.517445078 +0800 CST m=+91.538773699, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, size:0, steps:[0:{transfer leader from store 2 to store 3}], timeout:[1m0s])\""] [additional-info=]

I don't know the relationship between the failure test and this PR. It looks irrelevant.

[okJiang]

/test pull-integration-realcluster-test

[rleungx]

/hold

[rleungx]

/test pull-integration-realcluster-test

[rleungx]

/hold cancel

[nolouch]

I think the race problem's main reason is the task of accessing the object without protection. here still cannot avoid this kind of problem, we should let the task be safely run concurrency in task logic.

[rleungx]

Yes, indeed, but with the context, we can exit the goroutine ASAP.

[nolouch]

actually, I think it should pass context to the task, and then the task should consider exit ASAP by context cancel. here only prevent starting the new task. the initial version has this design :)

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HuSharp,nolouch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-15 08:07:11.063529194 +0000 UTC m=+254853.054470665: ☑️ agreed by HuSharp.
• 2024-07-22 09:53:41.700423425 +0000 UTC m=+866043.691364895: ☑️ agreed by nolouch.

[ti-chi-bot]

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.