raft: raft learners should be returned after applyConfChange #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
BusyJay
reviewed
Feb 9, 2018
tests/cases/test_raw_node.rs
Outdated
| let rd = raw_node.ready(); | ||
| s.wl().append(&rd.entries).expect(""); | ||
| for e in rd.committed_entries.as_ref().unwrap() { | ||
| if e.get_entry_type() == EntryType::EntryConfChange { |
There was a problem hiding this comment.
What if conf change entry is not found after iterating all entries?
There was a problem hiding this comment.
updated: check the committed_entries explicitly
|
@BusyJay test_remove_learner is updated now |
BusyJay
approved these changes
Feb 9, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12
add a new test test_raw_node_propose_add_learner_node() in test_raw_node.rs to cover the fix in apply_conf_change(..)