Feature blt and ostwind #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/clj/tramboard_clj/api/bvb.clj # src/clj/tramboard_clj/core/views.clj # src/cljs/tramboard_clj/script/util.cljs
and updated DB
chregu
force-pushed
the
feature-blt-ostwind
branch
from
3709b49
to
6002104
Compare
chregu
force-pushed
the
feature-blt-ostwind
branch
from
666fbf2
to
c59510a
Compare
| (do-api-call request-url transform-station-response) | ||
| (do-api-call2 request-url transform-station-response request-url-sbb (zvv/transform-station-response sbbid) get-hash)))) | ||
| (c/do-api-call request-url transform-station-response) | ||
| (c/do-api-call2 request-url transform-station-response request-url-sbb (zvv/transform-station-response sbbid) get-hash)))) |
There was a problem hiding this comment.
shall we name that differently ? :)
|
looks good! just that one little comment, after that you can merge i guess, you have the rights right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've hidden the to views in the web part for now, but it's used in the /ch/ view. Need some feedback first, how the data is. But apart from that, feel free to merge it ;)