-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilizing integral and interpolated integral #724
Conversation
bea0a57
to
4257d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we also need an arrow accessor for the interpolated_integral
. You can look at how I did this in #716 if you have any questions.
a6b9467
to
c280c50
Compare
None | ||
}; | ||
|
||
// Convert from num of milliseconds to DurationUnit and then to string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section of code is a workaround for the DurationUnit enum not working with the flat_serialize macro.
6e3123f
to
d5a6bc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just address the last few comments and this is ready to merge.
start : i64, | ||
interval : i64, | ||
prev : TimeWeightSummaryData, | ||
pad : [u8;3], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uff, bit late to do anything about this, but seems like we should have made our pg_type objects aligned so they could be composed without needing padding.
3eecfa5
to
85addbe
Compare
85addbe
to
79ccfbb
Compare
bors r+ |
Fixes #719