Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build deps(gopsutil) on darwin arm64 #161

Merged
merged 1 commit into from
May 14, 2021

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Apr 25, 2021

This PR fixes #160 by updating gopsutil to v3 given v2 is incompatible with Darwin arm64, as seen on shirou/gopsutil#1000.

@codecov-commenter
Copy link

Codecov Report

Merging #161 (f5d1513) into master (a045665) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   65.25%   65.25%           
=======================================
  Files         145      145           
  Lines        5966     5966           
=======================================
  Hits         3893     3893           
  Misses       1960     1960           
  Partials      113      113           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a045665...f5d1513. Read the comment docs.

Copy link
Contributor

@jonatas jonatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @filipecosta90! Tested locally and it works 🎉

@gkorland
Copy link

gkorland commented May 4, 2021

@jonatas thanks for approving the PR, can you please merge it?

@jonatas
Copy link
Contributor

jonatas commented May 13, 2021

@gkorland sorry for the delay, I'm checking with the project maintainers and we're going to merge it soon 🤞

@RobAtticus RobAtticus merged commit a7763a8 into timescale:master May 14, 2021
@filipecosta90 filipecosta90 deleted the fix.darwin.arm64 branch May 14, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binaries build fail on Apple M1
5 participants