This repository has been archived by the owner on Feb 9, 2020. It is now read-only.
Replace nan(T) with convert(T, NaN) to stop deprecation warnings in Julia v0.4 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
added a commit
that referenced
this pull request
Oct 29, 2014
Replace nan(T) with convert(T, NaN) to stop deprecation warnings in Julia v0.4
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Julia v0.4 will deprecate the nan(T) function in favour of convert(T, NaN). I was trying to get Grid working on v0.4 and changed this to stop the deprecation warnings.
Grid won't pass the rest of its tests on the v0.4 nightlies because of [#51], which I don't yet understand well enough to fix, but on v0.3 everything is fine.