Fix bug where plugin crashes if you specify the same page twice in yo…

…ur navigation
timvink · Oct 4, 2020 · cbc8a4d · cbc8a4d
1 parent dec3eb3
commit cbc8a4d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/mkdocs_print_site_plugin/plugin.py b/mkdocs_print_site_plugin/plugin.py
@@ -115,7 +115,7 @@ def on_config(self, config, **kwargs):
 
     def on_nav(self, nav, config, files, **kwargs):
 
-        # Save the (order of) pages in the navigation
+        # Save the (order of) pages in the navigation before adding the print page
         self.renderer.pages = nav.pages.copy()  # nav_pages
 
         # Optionally add the print page to the site navigation

diff --git a/mkdocs_print_site_plugin/renderer.py b/mkdocs_print_site_plugin/renderer.py
@@ -55,7 +55,9 @@ def write_combined(self):
             html += self._toc()
 
         # Update internal anchor links
-        page_htmls = [fix_internal_links(p.html, p.url) for p in self.pages]
+        # If you specify the same page in your navigation, it is only rendered once
+        # Hence the hasattr(p, 'html)
+        page_htmls = [fix_internal_links(p.html, p.url) for p in self.pages if hasattr(p, 'html')]
         html += "".join(page_htmls)
 
         html += "</div>"