Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite construct_df and add tests #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gedeck
Copy link

@gedeck gedeck commented Oct 1, 2022

Closes #16, #14, #9

  • Function construct_df is rewritten to work with the most recent pandas version.
  • Add infrastructure to run tests in docker containers
  • Add github actions to run tests using different Python versions (only done if github actions is enabled for this repository, free for public repositories)

See e.g. https://github.com/gedeck/doepy/actions/runs/3165946032 how github actions work

@gedeck gedeck marked this pull request as ready for review October 1, 2022 20:02
@hoechenberger
Copy link

Hello! What's the status on this? :)

@gedeck
Copy link
Author

gedeck commented Jan 24, 2023

I don't know. I use the package in an upcoming book (https://gedeck.github.io/mistat-code-solutions/IndustrialStatistics/) and was hoping that it would get fixed soon. Unfortunately, this hasn't happened yet, so I incorporated the code into the package that accompanies the book (https://github.com/gedeck/mistat, https://pypi.org/project/mistat/; import using from mistat.design import doe).

I'm not happy with this solution but it was the best I could do for now.

@hoechenberger
Copy link

Thanks for your swift response, @gedeck!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical issue: full_fact fails after recent update of pandas to 1.5.0
2 participants