fix shadow visibility on Windows (dotnet#10996)

tj-devel709 · Feb 21, 2023 · 99f86f8 · 99f86f8
1 parent 50a2ed8
commit 99f86f8
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/Core/src/Platform/Windows/WrapperView.cs b/src/Core/src/Platform/Windows/WrapperView.cs
@@ -33,6 +33,7 @@ public WrapperView()
 			Children.Add(_borderPath);
 		}
 
+		long _visibilityDependencyPropertyCallbackToken;
 		public FrameworkElement? Child
 		{
 			get { return _child; }
@@ -41,6 +42,7 @@ internal set
 				if (_child != null)
 				{
 					_child.SizeChanged -= OnChildSizeChanged;
+					_child.UnregisterPropertyChangedCallback(VisibilityProperty, _visibilityDependencyPropertyCallbackToken);
 					Children.Remove(_child);
 				}
 
@@ -49,6 +51,7 @@ internal set
 
 				_child = value;
 				_child.SizeChanged += OnChildSizeChanged;
+				_visibilityDependencyPropertyCallbackToken = _child.RegisterPropertyChangedCallback(VisibilityProperty, OnChildVisibilityChanged);
 				Children.Add(_child);
 			}
 		}
@@ -142,6 +145,16 @@ void OnChildSizeChanged(object sender, SizeChangedEventArgs e)
 			UpdateShadow();
 		}
 
+		void OnChildVisibilityChanged(DependencyObject sender, DependencyProperty dp)
+		{
+			// OnChildSizeChanged does not fire for Visibility changes to child
+			if (sender is FrameworkElement child && _shadowCanvas.Children.Count > 0)
+			{
+				var shadowHost = _shadowCanvas.Children[0];
+				shadowHost.Visibility = child.Visibility;
+			}
+		}
+
 		void DisposeShadow()
 		{
 			if (_shadowCanvas == null)