[wdspec] Avoid rounding issues with request timing assertions

Depends on D224442 Timings from the bidi network events have higher precision than what current_time returns, allow for an extra second in the time range to avoid intermittent failures for rounding issues. Differential Revision: https://phabricator.services.mozilla.com/D224444 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1922390 gecko-commit: a82529715a000d6e73101a936370a2c96da9f0db gecko-reviewers: webdriver-reviewers, Sasha
tkntjsdw · Oct 8, 2024 · 63a80de · 63a80de
1 parent 99020fb
commit 63a80de
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 17 deletions.
diff --git a/webdriver/tests/bidi/network/auth_required/auth_required.py b/webdriver/tests/bidi/network/auth_required/auth_required.py
@@ -116,7 +116,7 @@ async def test_request_timing_info(
     await wait_for_future_safe(on_auth_required)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
     expected_request = {"method": "GET", "url": auth_url}

diff --git a/webdriver/tests/bidi/network/before_request_sent/before_request_sent.py b/webdriver/tests/bidi/network/before_request_sent/before_request_sent.py
@@ -300,7 +300,7 @@ async def test_request_timing_info(
     await wait_for_future_safe(on_before_request_sent)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -473,7 +473,7 @@ async def test_serviceworker_request(
     await wait_for_future_safe(on_before_request_sent)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -506,7 +506,7 @@ async def test_url_with_fragment(
     await wait_for_future_safe(on_before_request_sent)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -551,7 +551,7 @@ async def test_navigate_data_url(
     await wait_for_future_safe(on_before_request_sent)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -594,7 +594,7 @@ async def test_fetch_data_url(
     await wait_for_future_safe(on_before_request_sent)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 

diff --git a/webdriver/tests/bidi/network/fetch_error/fetch_error.py b/webdriver/tests/bidi/network/fetch_error/fetch_error.py
@@ -240,7 +240,7 @@ async def test_request_timing_info(
     await wait_for_future_safe(on_fetch_error)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
     expected_request = {"method": "GET", "url": PAGE_INVALID_URL}

diff --git a/webdriver/tests/bidi/network/response_completed/response_completed.py b/webdriver/tests/bidi/network/response_completed/response_completed.py
@@ -179,7 +179,7 @@ async def test_request_timing_info(
     await wait_for_future_safe(on_response_completed)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -448,7 +448,7 @@ async def test_serviceworker_request(
     await wait_for_future_safe(on_response_completed)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -485,7 +485,7 @@ async def test_url_with_fragment(
     await wait_for_future_safe(on_response_completed)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -533,7 +533,7 @@ async def test_navigate_data_url(
     await wait_for_future_safe(on_response_completed)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -586,7 +586,7 @@ async def test_fetch_data_url(
     await wait_for_future_safe(on_response_completed)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 

diff --git a/webdriver/tests/bidi/network/response_started/response_started.py b/webdriver/tests/bidi/network/response_started/response_started.py
@@ -187,7 +187,7 @@ async def test_request_timing_info(
     await wait_for_future_safe(on_response_started)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -421,7 +421,7 @@ async def test_serviceworker_request(
     await wait_for_future_safe(on_response_started)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -458,7 +458,7 @@ async def test_url_with_fragment(
     await wait_for_future_safe(on_response_started)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -506,7 +506,7 @@ async def test_navigate_data_url(
     await wait_for_future_safe(on_response_started)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1
 
@@ -559,7 +559,7 @@ async def test_fetch_data_url(
     await wait_for_future_safe(on_response_started)
 
     time_end = await current_time()
-    time_range = number_interval(time_start, time_end)
+    time_range = number_interval(time_start - 1, time_end + 1)
 
     assert len(events) == 1