Skip to content

Commit

Permalink
Merging before PR because of release stemma editor.
Browse files Browse the repository at this point in the history 
Merge branch 'd3bootstrap' into d3bootstrap_delsec.
  • Loading branch information
@jorisvanzundert
jorisvanzundert committed Feb 13, 2024
2 parents 88af2a7 + a109bc5 commit 479d3d9
Showing 1 changed file with 126 additions and 17 deletions.
143 changes: 126 additions & 17 deletions frontend-e2e/cypress/e2e/stemwebdialog.cy.js
View file
Original file line number Diff line number Diff line change
@@ -1,32 +1,49 @@
/* gui element to run stemweb
https://github.com/tla/stemmaweb/pull/172#issue-1680053781
1)
refactor: small tweaks to button colors
refactor: replace space in ids for inputs in dropdowns with '-' (todo issued as #171)
feature: alphabetic compare function in utils.js
refactor: changed adding of eventlisteners in stemmaButtons.js
Tests to add:
click on button "Run Stemweb" should open Stemweb dialog
Dropdown should show names of Stemweb algorithms (currently: RHM, Neighbour joining, and Neighbour net)
Click info badge ('i') should show description of algorithm
Click on RHM should reveal argument field 'Iterations'
Click on other algorithms should not show any argument fields
Click on Cancel or anywhere outside dialog closes dialog
Click on "Run" (not implemented yet, just closes dialog for now)
Click on "Run" shows a success message 'Job added' and closes dialog
2)
Run a StemWeb algorithm and fetch results (backend) #103
https://github.com/tla/stemmaweb/pull/185#issue-2050160053
Cypress tests that could be added:
Florilegium shows a status of:
Job: 2
Status: Running
Arabic snippet shows a status of:
Job: 3
Status: Error
Result: Pretend we had an error here.
Notre Besoin traditions shows a status of:
Job: 1
Status: Done
*/

import test_traditions from '../fixtures/test_traditions.json';
import stemweb_algorithms from '../fixtures/stemweb_algorithms.json'
const len_stemweb_algorithms = stemweb_algorithms.length;

beforeEach(() => {
cy.visit(`${Cypress.env('CY_STEMMAWEB_FRONTEND_URL')}/`);
cy.viewport(1600, 900);
});

describe('Stemweb dialog should work properly', () => {
it('under construction', () => {
it('passes', () => {
// click on button "Run Stemweb" should open Stemweb dialog
cy.contains('Run Stemweb').click();
cy.get('stemmaweb-dialog .modal-content').as('stemwebmodal');
Expand All @@ -40,7 +57,7 @@ describe('Stemweb dialog should work properly', () => {
const optionText = $el.text().trim();
cy.get('@stemwebmodal').find('select').select(optionText); // click on optionText
cy.get('@stemwebmodal').find('select option:selected') // get the selected option
.invoke("text").then((txt) => {
.invoke('text').then((txt) => {
const selected = txt.trim();
expect(selected).equal(optionText); // ok, desired option is selected
expect(optionText).equal(stemweb_algorithms[index].text); // and it matches the test data
Expand All @@ -66,26 +83,118 @@ describe('Stemweb dialog should work properly', () => {

// Click on Cancel closes dialog
cy.get('@stemwebmodal').should('be.visible');
cy.get('@stemwebmodal').find('button').contains('Cancel').trigger('mouseover').click();
cy.get('@stemwebmodal').find('button').contains('Cancel').wait(500).click();
cy.get('@stemwebmodal').should('not.be.visible');

// Click on "Run" (not implemented yet, just closes dialog for now)
cy.contains('Run Stemweb').click();
cy.get('stemmaweb-dialog .modal-content').as('stemwebmodal');
cy.get('@stemwebmodal').contains('Generate a Stemweb tree').should('be.visible');
cy.get('@stemwebmodal').find('button').contains('Run').its('length').then((len) => {cy.log('length:' + len)});
cy.get('@stemwebmodal').find('button').contains('Run').trigger('mouseover').click();
cy.get('@stemwebmodal').should('not.be.visible'); // fuzzy

// Click on anywhere outside dialog closes dialog
cy.contains('Run Stemweb').click();
cy.get('stemmaweb-dialog .modal-content').as('stemwebmodal');
cy.get('@stemwebmodal').contains('Generate a Stemweb tree').should('be.visible');
cy.get('@stemwebmodal').closest("#modalDialog").then((elem) => {
cy.log("#modalDialog:", elem);
cy.get('@stemwebmodal').closest('#modalDialog').then((elem) => {
cy.log('#modalDialog:' + elem);
});
cy.get('@stemwebmodal').closest("#modalDialog").its('length').then((len) => {cy.log('length:' + len)}); // seems to help against fuzziness
cy.get('@stemwebmodal').closest("#modalDialog").trigger('mouseover', { 'timeout': 10000 }).click('left');
cy.get('@stemwebmodal').closest('#modalDialog').as('mdialog');
// cy.get('@mdialog').its('length').then((len) => {cy.log('length:' + len)});
cy.get('@mdialog').wait(500).click('left');
cy.get('@stemwebmodal').should('not.be.visible');

// for any algorithm open the modal again to assert 'Job added' and dialog closed
for(const algorithm of stemweb_algorithms) {
cy.reload();
cy.log('algorithm.text: ' + algorithm.text)
cy.contains('Run Stemweb').wait(500).click();
cy.get('stemmaweb-dialog .modal-content').as('stemwebmodal');
cy.get('@stemwebmodal').contains('Generate a Stemweb tree').should('be.visible');

cy.get('@stemwebmodal').find('select>option')
.each(($el) => {
const optionText = $el.text().trim();
cy.log('optionText:' + optionText)
if (algorithm.text === optionText){
cy.get('@stemwebmodal').find('select').select(optionText); // click on optionText
if (optionText === 'Pars') {
// TODO: Issue #187 with Pars algorithm, not "Job added" but "Error: INTERNAL SERVER ERROR"
} else {
// Click on "Run" shows a success message 'Job added'
// and closes dialog
cy.get('@stemwebmodal').find('button').contains('Run').wait(500).click(); // wait() for the event listener to close the modal to be attached (https://www.cypress.io/blog/2019/01/22/when-can-the-test-click)
cy.get('stemmaweb-alert').contains('Job added');
cy.get('@stemwebmodal').should('not.be.visible');
}
}
});
}
});
});

describe('Runs a StemWeb algorithm and fetches results (backend)', () => {
// https://github.com/tla/stemmaweb/issues/103
// https://github.com/tla/stemmaweb/pull/185

it('passes', () => {
test_traditions.forEach((tradition) => {
const traditionTitle = tradition.title;
cy.log('traditionTitle: ' + traditionTitle);

// get the toc entry for the tradition which starts with Florilegium and click on it,
// the same for Arabic snippet and for Notre besoin.
if (traditionTitle.startsWith("Florilegium")) {
cy.get('#traditions-list').contains(traditionTitle).click();
cy.contains('Run Stemweb').click();
cy.get('stemmaweb-dialog .modal-content').as('stemwebmodal');
cy.get('@stemwebmodal').contains('Generate a Stemweb tree').should('be.visible');
cy.get('@stemwebmodal').find('button').contains('Run').wait(500).click();
cy.get('stemmaweb-alert').contains('Job added');
cy.get('@stemwebmodal').should('not.be.visible');
// Florilegium shows a status of: Job: 2. Status: Running
// data to be asserted within the stemweb-job-status element
cy.get('stemweb-job-status').contains('#job_status', '2').and('contain.text', 'Running');
} else if (traditionTitle.startsWith("Arabic snippet")) {
cy.get('#traditions-list').contains(traditionTitle).click();
cy.contains('Run Stemweb').click();
cy.get('stemmaweb-dialog .modal-content').as('stemwebmodal');
cy.get('@stemwebmodal').contains('Generate a Stemweb tree').should('be.visible');
cy.get('@stemwebmodal').find('button').contains('Run').wait(500).click();
cy.get('stemmaweb-alert').contains('Job added');
cy.get('@stemwebmodal').should('not.be.visible');
// Arabic snippet shows a status of: Job: 3. Status: Error. Result: Pretend we had an error here.
cy.get('stemweb-job-status').contains('#job_status', '3').and('contain.text', 'Error').and('contain.text', 'Pretend we had an error here.');
} else if (traditionTitle.startsWith("Notre besoin")) {
cy.get('#traditions-list').contains(traditionTitle).click();
cy.contains('Run Stemweb').click();
cy.get('stemmaweb-dialog .modal-content').as('stemwebmodal');
cy.get('@stemwebmodal').contains('Generate a Stemweb tree').should('be.visible');
cy.get('@stemwebmodal').find('button').contains('Run').wait(500).click();
cy.get('stemmaweb-alert').contains('Job added');
cy.get('@stemwebmodal').should('not.be.visible');
// Notre Besoin tradition shows a status of: Job: 1. Status: Done
cy.get('stemweb-job-status').contains('#job_status', '1').and('contain.text', 'Done');
// traditions for which Stemweb has not been run should not display the stemweb-job-status
} else {
cy.get('#traditions-list').contains(traditionTitle).click();
cy.get('stemweb-job-status').should('not.be.visible');
}

// stemweb-job-status should still be there after coming back from clicking on other traditions
test_traditions.reverse().forEach((tradition) => {
const traditionTitle = tradition.title;
cy.log('traditionTitle: ' + traditionTitle);
cy.get('#traditions-list').contains(traditionTitle).click();
if (traditionTitle.startsWith("Florilegium")) {
// Notre Besoin tradition shows a status of: Job: 1. Status: Done
cy.get('stemweb-job-status').contains('#job_status', '2').and('contain.text', 'Running');
} else if (traditionTitle.startsWith("Arabic snippet")) {
// Arabic snippet shows a status of: Job: 3. Status: Error. Result: Pretend we had an error here.
cy.get('stemweb-job-status').contains('#job_status', '3').and('contain.text', 'Error').and('contain.text', 'Pretend we had an error here.');
} else if (traditionTitle.startsWith("Notre besoin")) {
// Notre Besoin tradition shows a status of: Job: 1. Status: Done
cy.get('stemweb-job-status').contains('#job_status', '1').and('contain.text', 'Done');
} else {
// traditions for which Stemweb has not been run should not display the stemweb-job-status
cy.get('#traditions-list').contains(traditionTitle).click();
cy.get('stemweb-job-status').should('not.be.visible');
}
});
});
});
});

0 comments on commit 479d3d9

Please sign in to comment.